From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] xsm_remove_from_physmap is (so far) only defined for X86 architecture, not for ARM Date: Fri, 11 Jan 2013 16:36:33 +0000 Message-ID: References: <24906FE8-94BF-4694-9E2A-3737A5686405@sics.se> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <24906FE8-94BF-4694-9E2A-3737A5686405@sics.se> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Lars Rasmusson Cc: Ian Campbell , Daniel De Graaf , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 11/01/2013 16:24, "Lars Rasmusson" wrote: >> On 11/01/2013 13:32, "lra@sics.se" wrote: >> >>> From: Lars Rasmusson >>> >>> Signed-off-by: Lars Rasmusson >> >> If this is a build fix after my checkins this morning then: >> Acked-by: Keir Fraser > > Yes, the XEN_TARGET_ARCH=arm32 make breaks when compiling memory.c > > In xen/include/xsm/dummy.h where many of the functions are used, some are > declared only for X86, so I picked the same #ifdef CONFIG_X86 > as the header file uses. > > As Ian said, it's not pretty, but since ARM doesn't have xsm (yet?) I think > adding a dummy xsm_remove_from_physmap for arm also is ugly. > > Is there some other way to write memory.c so that it doesn't need > xsm_remove...? (I mean, it does't need xsm_add....) The XSM infrastructure is not architecture dependent. It's probably a mistake that xsm_remove_from_physmap() is ifdef CONFIG_X86. -- Keir