From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 00/11] x86: support up to 16Tb Date: Wed, 23 Jan 2013 10:16:35 +0000 Message-ID: References: <50FFC1E102000078000B89AA@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50FFC1E102000078000B89AA@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 23/01/2013 09:56, "Jan Beulich" wrote: >>>> On 23.01.13 at 10:33, Keir Fraser wrote: >> There's an 'ifdef PAGE_LIST_NULL' in patch 11 in x86/setup.c. Is that really >> needed? > > That's there so that once we go beyond 16Tb the code won't need > to change. In particular, because of the implied growth of struct > page_info, I'm envisioning such support to become optional (to be > enabled at build time). Defer the ifdef until it's needed, then when it's added its in the sensible place (ie. where PAGE_LIST_NULL really does become build-time optional). -- Keir > Jan >