From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH v2 1/2] x86: defer processing events on the
	NMI exit path
Date: Fri, 01 Mar 2013 15:56:16 +0000
Message-ID: <CD568020.5D214%keir@xen.org>
References: <5130A4E002000078000C2557@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5130A4E002000078000C2557@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Malcolm Crossley <malcolm.crossley@citrix.com>, "Tim (Xen.org)" <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 01/03/2013 11:53, "Jan Beulich" <JBeulich@suse.com> wrote:

>> __softirq_pending is an unsigned long.  Would it not be prudent to use
>> cmpq to save obscure bugs if the implementation changes, or are we
>> sufficiently sure that this wont happen?
> 
> All other existing instances of similar assembly code use testl or
> cmpl, and in fact I merely copied some other instance.
> 
> As we're not getting close to 32, I think we might rather want to
> adjust the __softirq_pending type. Keir?

Yup, I don't see any reason why it couldn't be a uint32_t.

 -- Keir