From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: use tasklet to handle init/sipi? Date: Tue, 26 Mar 2013 07:38:37 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Zhang, Yang Z" , "xen-devel@lists.xen.org" Cc: "Qiu, Shuang" , "Zhang, Xiantao" , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 26/03/2013 07:17, "Zhang, Yang Z" wrote: >>> Oh, I see. Well I think it is fine to have >>> vlapic_schedule_init_sipi_tasklet() return X86EMUL_OKAY rather than >>> X86EMUL_RETRY. We used to need to return RETRY, but the code got simplified >>> and now it is actually unnecessary. >>> >>> That should make your patch a lot simpler eh? ;) >> >> Given that you ignore the return code on the apicv call path, is there >> currently a bug at all for you? Seems what is there already must work >> for you? > It do cause bug after we change to use seabios. For seabios, it will send > INIT/SIPI to all vcpus via broadcasting. And there only one vcpu is waken up > via tasklet with current logic. That's the reason why I want to wakeup all > vcpus on one callback. > Just change X86EMUL_RETRY to OK cannot solve the problem. still need the logic > I mentioned above. Ok, wait a sec, I will sort out a patch for you to try... -- Keir