From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/EFI: permit setting variable with non-zero attributes
Date: Tue, 26 Mar 2013 17:20:26 +0000 [thread overview]
Message-ID: <CD77895A.4EA76%keir.xen@gmail.com> (raw)
In-Reply-To: <5151E1D102000078000C8AC0@nat28.tlf.novell.com>
On 26/03/2013 16:58, "Jan Beulich" <JBeulich@suse.com> wrote:
> This must have been a copy-and-paste mistake - get_variable uses
> op->misc as output only, and wants to make sure it's zero for future
> extensibility. For set_variable, this is an input though, and hence
> the check is wrong.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/efi/runtime.c
> +++ b/xen/arch/x86/efi/runtime.c
> @@ -398,9 +398,6 @@ int efi_runtime_call(struct xenpf_efi_ru
> long len;
> unsigned char *data;
>
> - if ( op->misc )
> - return -EINVAL;
> -
> len = gwstrlen(guest_handle_cast(op->u.set_variable.name, CHAR16));
> if ( len < 0 )
> return len;
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2013-03-26 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 16:58 [PATCH] x86/EFI: permit setting variable with non-zero attributes Jan Beulich
2013-03-26 17:20 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CD77895A.4EA76%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).