[PATCH] x86/EFI: permit setting variable with non-zero attributes

[PATCH] x86/EFI: permit setting variable with non-zero attributes

[Jan Beulich]

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

This must have been a copy-and-paste mistake - get_variable uses
op->misc as output only, and wants to make sure it's zero for future
extensibility. For set_variable, this is an input though, and hence
the check is wrong.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/efi/runtime.c
+++ b/xen/arch/x86/efi/runtime.c
@@ -398,9 +398,6 @@ int efi_runtime_call(struct xenpf_efi_ru
         long len;
         unsigned char *data;
 
-        if ( op->misc )
-            return -EINVAL;
-
         len = gwstrlen(guest_handle_cast(op->u.set_variable.name, CHAR16));
         if ( len < 0 )
             return len;




[-- Attachment #2: x86-EFI-set-variable-permit-attrs.patch --]
[-- Type: text/plain, Size: 711 bytes --]

x86/EFI: permit setting variable with non-zero attributes

This must have been a copy-and-paste mistake - get_variable uses
op->misc as output only, and wants to make sure it's zero for future
extensibility. For set_variable, this is an input though, and hence
the check is wrong.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/efi/runtime.c
+++ b/xen/arch/x86/efi/runtime.c
@@ -398,9 +398,6 @@ int efi_runtime_call(struct xenpf_efi_ru
         long len;
         unsigned char *data;
 
-        if ( op->misc )
-            return -EINVAL;
-
         len = gwstrlen(guest_handle_cast(op->u.set_variable.name, CHAR16));
         if ( len < 0 )
             return len;

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] x86/EFI: permit setting variable with non-zero attributes

[Keir Fraser]

On 26/03/2013 16:58, "Jan Beulich" <JBeulich@suse.com> wrote:

> This must have been a copy-and-paste mistake - get_variable uses
> op->misc as output only, and wants to make sure it's zero for future
> extensibility. For set_variable, this is an input though, and hence
> the check is wrong.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/arch/x86/efi/runtime.c
> +++ b/xen/arch/x86/efi/runtime.c
> @@ -398,9 +398,6 @@ int efi_runtime_call(struct xenpf_efi_ru
>          long len;
>          unsigned char *data;
>  
> -        if ( op->misc )
> -            return -EINVAL;
> -
>          len = gwstrlen(guest_handle_cast(op->u.set_variable.name, CHAR16));
>          if ( len < 0 )
>              return len;
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel