xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>,
	Stefan Bader <stefan.bader@canonical.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Eddie Dong <eddie.dong@intel.com>,
	wei.y.yang@intel.com, haitao.shan@intel.com,
	Dongxiao Xu <dongxiao.xu@intel.com>,
	xin.li@intel.com, Jun Nakajima <jun.nakajima@intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xiantao.zhang@intel.com
Subject: Re: Xen HVM regression on certain Intel CPUs
Date: Wed, 03 Apr 2013 15:28:05 +0100	[thread overview]
Message-ID: <CD81FB05.1FD9A%keir.xen@gmail.com> (raw)
In-Reply-To: <515C402A02000078000CA55C@nat28.tlf.novell.com>

On 03/04/2013 13:43, "Jan Beulich" <JBeulich@suse.com> wrote:

>>>> On 03.04.13 at 13:56, Stefan Bader <stefan.bader@canonical.com> wrote:
>> I added some more debugging output to the hypervisor to verify the state of
>> HAP.
>> This showed that while HAP is available on the system, it is not used for the
>> HVM guests. It looks like this would require some flags to be set when
>> creating
>> the guest domains and I assume this is not happening because I have to stay
>> with
>> the xm stack for the libvirt setup for now (requires some repackaging which
>> hasn't been done, yet).
>> 
>> So the guest isn't using HAP but does seem to use some form of paging even if
>> the guest VCPU is not using paging. So I changed the vmx_update_guest_cr()
>> function in that way and that seems to prevent the hangs. Does this look like
>> a
>> reasonable upstream Xen change?
> 
> Yes, it looks appropriate. But I'd like this to be confirmed by the
> authors of the original change and/or the VMX maintainers (added
> to Cc).

It can have my ack straight away.

Acked-by: Keir Fraser <keir@xen.org>

Nonetheless it would be nice to get a VMX maintainer ack too, though I'm
pretty sure this patch is correct.

 -- Keir

> Nevertheless it's very odd to not use HAP on a machine capable
> of it...
> 
> Jan
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

  reply	other threads:[~2013-04-03 14:28 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 15:26 Xen HVM regression on certain Intel CPUs Stefan Bader
2013-03-27 15:53 ` Stefan Bader
2013-03-27 16:04   ` Konrad Rzeszutek Wilk
2013-03-27 16:09     ` H. Peter Anvin
2013-03-27 16:24       ` Stefan Bader
2013-03-27 16:32         ` H. Peter Anvin
2013-03-27 16:32         ` Stefano Stabellini
2013-03-27 16:45     ` Stefan Bader
2013-03-27 16:52       ` H. Peter Anvin
2013-03-27 17:17         ` Stefan Bader
2013-03-27 17:23           ` H. Peter Anvin
2013-03-27 17:38             ` Stefan Bader
2013-03-28 13:34             ` Jan Beulich
2013-03-28 15:02               ` Stefan Bader
2013-03-28 16:39                 ` Stefan Bader
2013-04-03 11:56                   ` Stefan Bader
2013-04-03 12:43                     ` Jan Beulich
2013-04-03 14:28                       ` Keir Fraser [this message]
2013-04-03 15:00                         ` Xu, Dongxiao
2013-04-03 15:48                           ` H. Peter Anvin
2013-04-03 16:05                             ` Jan Beulich
2013-03-27 17:28       ` Stefan Bader
2013-03-27 17:30         ` H. Peter Anvin
2013-03-27 17:40           ` Stefan Bader
2013-03-27 17:44             ` H. Peter Anvin
2013-03-27 20:24       ` Keir Fraser
2013-03-28 15:06         ` Stefan Bader
2013-03-28 15:42           ` H. Peter Anvin
2013-03-28 16:12             ` Stefan Bader
2013-03-27 16:18   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CD81FB05.1FD9A%keir.xen@gmail.com \
    --to=keir.xen@gmail.com \
    --cc=JBeulich@suse.com \
    --cc=dongxiao.xu@intel.com \
    --cc=eddie.dong@intel.com \
    --cc=haitao.shan@intel.com \
    --cc=hpa@zytor.com \
    --cc=jun.nakajima@intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=stefan.bader@canonical.com \
    --cc=wei.y.yang@intel.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xiantao.zhang@intel.com \
    --cc=xin.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).