From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH v3 03/13] xen: introduce cpumask_from_bitmap Date: Thu, 25 Apr 2013 15:26:24 +0100 Message-ID: References: <1366884072.20256.448.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1366884072.20256.448.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Jan Beulich Cc: Julien Grall , "Tim (Xen.org)" , xen-devel , "Keir (Xen.org)" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 25/04/2013 11:01, "Ian Campbell" wrote: >> And most importantly: Why? This isn't an operation that should >> commonly be done, and hence having a utility function for this >> seems to invite for abuse rather than really help. > > I suggested it, we are emulating an instruction which provides a bitmap > of the CPUs to operate on. It seemed nicer to me to have a helper rather > than to open-code accesses under the hood of the cpumask interface. Emulating a guest instruction? And it really wants to act on sets of real physical cpus (hence cpumask_t)? -- Keir