From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH v3 03/13] xen: introduce cpumask_from_bitmap Date: Thu, 25 Apr 2013 16:17:19 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , Ian Campbell Cc: Julien Grall , "Tim (Xen.org)" , Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org On 25/04/2013 16:08, "Stefano Stabellini" wrote: > On Thu, 25 Apr 2013, Ian Campbell wrote: >> On Thu, 2013-04-25 at 15:42 +0100, Ian Campbell wrote: >>> And it really wants to act on sets of real physical cpus (hence cpumask_t)? >> >> Actually, vcpus. Perhaps cpumask_t is the wrong datatype then? > > It seems to me that cpumask_t is a pretty good fit for a vcpu mask. It's not. It's bounded by NR_CPUS for a start. And it is good documentation for all uses of cpumasks to be applying to *physical* cpus, otherwise we will end up even more confused! I might consider a vcpumask_t of some sort if such an abstraction could be made to work out nicely (given different domains have different max# of vcpus). But we managed so far without. ;) -- Keir