From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH v4] Use {git, hg, svn} commit id if available for xen_changeset Date: Mon, 13 May 2013 12:43:39 +0100 Message-ID: References: <1368438588.537.20.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1368438588.537.20.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Andrew Cooper Cc: Sander Eikelenboom , Marek Marczykowski , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 13/05/2013 10:49, "Ian Campbell" wrote: > On Fri, 2013-05-10 at 14:33 +0100, Andrew Cooper wrote: >> On 10/05/13 14:29, Ian Campbell wrote: >>> On Thu, 2013-05-09 at 00:07 +0100, Marek Marczykowski wrote: >>>> As Xen uses git as primary repository, get git commit id for >>>> xen_changeset info. >>>> >>>> Changes in v2: >>>> - split scm calls into separate script - based on Linux kernel one, >>>> with tags handling removed >>>> >>>> Changes in v3: >>>> - do not assume tools/scmversion started from the repository toplevel >>>> dir - it is actually called from xen/ subdir >>>> >>>> Changes in v4: >>>> - restore checks for .git and .hg dirs, use $(XEN_ROOT) >>>> >>>> Signed-off-by: Marek Marczykowski >>> I tried this on git and hg and it appeared to do the right thing, >>> thanks. >>> >>> Reviewed-by: Ian Campbell >> >> As soon as this gets into staging, I will rebase my much older patch on >> top to allow XEN_CHANGESET to be overridden on the make invocation. > > Thanks. It needs an Ack from a hypervisor maintainer first (Keir > presumably). Okay, well it looked quite fine to me :) Acked-by: Keir Fraser > Ian. >