From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: Xen 4.3 + tmem = Xen BUG at domain_page.c:143
Date: Wed, 12 Jun 2013 18:26:44 +0100 [thread overview]
Message-ID: <CDDE6DE4.54D3B%keir.xen@gmail.com> (raw)
In-Reply-To: <51B8B46A02000078000DDAAF@nat28.tlf.novell.com>
On 12/06/2013 16:48, "Jan Beulich" <JBeulich@suse.com> wrote:
>> Why are we so tight on MAPCACHE_VCPU_ENTRIES? Why not say double that number
>> and get rid of the accum and the 'replace a hash entry instead' logic
>> instead? We never used to have it, and it's kind of extra complication and a
>> bit gross.
>
> First of all, doubling the entries is not an argument for dropping
> that code - the old 32-bit implementation really would have
> needed this too from a theoretical perspective: The number of
> readily available (garbage) entries is bounded by
> MAPCACHE_VCPU_ENTRIES - MAPHASH_ENTRIES (because the
> hash entries actively block getting treated as garbage).
So? We have control over both MAPCACHE_VCPU_ENTRUES and MAPHASH_ENTRIES. We
can make these somewhat arbitrary constants big
next prev parent reply other threads:[~2013-06-12 17:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 13:45 Xen 4.3 + tmem = Xen BUG at domain_page.c:143 konrad wilk
2013-06-11 14:46 ` Jan Beulich
2013-06-11 15:30 ` konrad wilk
2013-06-11 15:56 ` George Dunlap
2013-06-11 16:38 ` Jan Beulich
2013-06-11 17:30 ` konrad wilk
2013-06-11 18:52 ` konrad wilk
2013-06-11 21:06 ` konrad wilk
2013-06-12 6:38 ` Jan Beulich
2013-06-12 11:00 ` George Dunlap
2013-06-12 11:15 ` Processed: " xen
2013-06-12 11:37 ` George Dunlap
2013-06-12 12:46 ` Jan Beulich
2013-06-12 14:13 ` Konrad Rzeszutek Wilk
2013-06-12 12:12 ` Jan Beulich
2013-06-12 13:16 ` George Dunlap
2013-06-12 13:27 ` Jan Beulich
2013-06-12 15:11 ` Keir Fraser
2013-06-12 15:27 ` Keir Fraser
2013-06-12 15:54 ` Jan Beulich
2013-06-12 15:48 ` Jan Beulich
2013-06-12 17:26 ` Keir Fraser [this message]
2013-07-05 16:56 ` George Dunlap
2013-07-08 8:58 ` Jan Beulich
2013-07-08 9:07 ` George Dunlap
2013-07-08 9:15 ` Processed: " xen
2013-07-08 9:25 ` George Dunlap
2013-07-08 9:30 ` Processed: " xen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CDDE6DE4.54D3B%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).