From: Keir Fraser <keir.xen@gmail.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>
Cc: Hanweidong <hanweidong@huawei.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v4 1/8] hvmloader: Remove all 64-bit print arguments
Date: Fri, 21 Jun 2013 12:20:18 +0100 [thread overview]
Message-ID: <CDE9F582.2A831%keir.xen@gmail.com> (raw)
In-Reply-To: <20932.12167.39614.419035@mariner.uk.xensource.com>
On 21/06/2013 11:48, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:
> George Dunlap writes ("[PATCH v4 1/8] hvmloader: Remove all 64-bit print
> arguments"):
>> The printf() available to hvmloader does not handle 64-bit data types;
>> manually break them down as two 32-bit strings.
>>
>> v4:
>> - Make macros for the requisite format and bit shifting
>
> This is an improvement.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Keir Fraser <keir@xen.org>
I like it because it makes it easy to go implement %llx properly later. I
think it's dumb we're not doing that now to be honest, we have code in Xen
that could be pinched.
-- Keir
next prev parent reply other threads:[~2013-06-21 11:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 10:46 [PATCH 0/8] Relocate devices rather than memory for qemu-xen George Dunlap
2013-06-21 10:46 ` [PATCH v4 1/8] hvmloader: Remove all 64-bit print arguments George Dunlap
2013-06-21 10:48 ` Ian Jackson
2013-06-21 11:20 ` Keir Fraser [this message]
2013-06-21 10:55 ` Stefano Stabellini
2013-06-21 10:46 ` [PATCH v4 2/8] hvmloader: Make the printfs more informative George Dunlap
2013-06-21 10:49 ` Ian Jackson
2013-06-21 10:57 ` Stefano Stabellini
2013-06-21 10:46 ` [PATCH v4 3/8] hvmloader: Set up highmem resouce appropriately if there is no RAM above 4G George Dunlap
2013-06-21 10:50 ` Ian Jackson
2013-06-21 11:11 ` Stefano Stabellini
2013-06-21 10:46 ` [PATCH v4 4/8] hvmloader: Fix check for needing a 64-bit bar George Dunlap
2013-06-21 10:51 ` Ian Jackson
2013-06-21 10:46 ` [PATCH v4 5/8] hvmloader: Correct bug in low mmio region accounting George Dunlap
2013-06-21 11:19 ` Ian Jackson
2013-06-21 12:58 ` Jan Beulich
2013-06-21 13:32 ` Ian Jackson
2013-06-21 13:40 ` George Dunlap
2013-06-21 10:46 ` [PATCH v4 6/8] hvmloader: Load large devices into high MMIO space as needed George Dunlap
2013-06-21 11:21 ` Ian Jackson
2013-06-21 10:46 ` [PATCH v4 7/8] hvmloader: Remove minimum size for BARs to relocate to 64-bit space George Dunlap
2013-06-21 11:22 ` Ian Jackson
2013-06-21 10:46 ` [PATCH v4 8/8] libxl, hvmloader: Don't relocate memory for MMIO hole George Dunlap
2013-06-21 11:15 ` Stefano Stabellini
2013-06-21 11:25 ` Ian Jackson
2013-06-26 10:08 ` Hao, Xudong
2013-06-26 13:36 ` Stefano Stabellini
2013-06-26 14:23 ` Hao, Xudong
2013-06-26 16:21 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CDE9F582.2A831%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=hanweidong@huawei.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).