Re: Ping: revert commit e4fd0475 ("hvmloader: always include HPET table")

[Keir Fraser <keir.xen@gmail.com>]

On 08/07/2013 11:05, "Jan Beulich" <JBeulich@suse.com> wrote:

>>>> On 03.07.13 at 13:45, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 03/07/2013 13:43, Jan Beulich ha scritto:
>>> Windows SVVP tests requiring a HPET ACPI table is in my opinion
>>> not a valid reason to always expose that table - respective tests
>>> should be run with "hpet=1" in the guest config file.
>>> 
>>> The problem here is that at least with qemu-traditional, which
>>> by default doesn't appear to emulate a HPET,
>> 
>> Isn't the HPET emulated in the hypervisor anyway?
>> 
>>> the advertising
>>> here can mislead an OS to believe that there actually is a usable
>>> HPET, which isn't true when neither Xen nor qemu emulate one.
>>> This ie being observed in reality: SLES9, being 2.6.5 based,
>>> doesn't have enough checking to notice that the HPET doesn't
>>> actually work.
>> 
>> Fair enough, the oldest I tested at the time was 2.6.9.
> 
> Any opinion on this, Keir? You're the defacto maintainer of
> hvmloader (perhaps worth an explicit entry in MAINTAINERS), so
> I'd need your ack for reverting said change.

You're right, this patch was a horrible mistake. Please do revert it.

 -- Keir

> Alternatively, Ian, Ian, Stefano - any opinion (as this is formally
> living under tools/)?
> 
> Jan
>