From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Ping: revert commit e4fd0475 ("hvmloader: always include HPET table") Date: Mon, 08 Jul 2013 11:39:23 +0100 Message-ID: References: <51DAAB0A02000078000E3384@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51DAAB0A02000078000E3384@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Ian Campbell , Ian Jackson , Stefano Stabellini Cc: Paolo Bonzini , xen-devel List-Id: xen-devel@lists.xenproject.org On 08/07/2013 11:05, "Jan Beulich" wrote: >>>> On 03.07.13 at 13:45, Paolo Bonzini wrote: >> Il 03/07/2013 13:43, Jan Beulich ha scritto: >>> Windows SVVP tests requiring a HPET ACPI table is in my opinion >>> not a valid reason to always expose that table - respective tests >>> should be run with "hpet=1" in the guest config file. >>> >>> The problem here is that at least with qemu-traditional, which >>> by default doesn't appear to emulate a HPET, >> >> Isn't the HPET emulated in the hypervisor anyway? >> >>> the advertising >>> here can mislead an OS to believe that there actually is a usable >>> HPET, which isn't true when neither Xen nor qemu emulate one. >>> This ie being observed in reality: SLES9, being 2.6.5 based, >>> doesn't have enough checking to notice that the HPET doesn't >>> actually work. >> >> Fair enough, the oldest I tested at the time was 2.6.9. > > Any opinion on this, Keir? You're the defacto maintainer of > hvmloader (perhaps worth an explicit entry in MAINTAINERS), so > I'd need your ack for reverting said change. You're right, this patch was a horrible mistake. Please do revert it. -- Keir > Alternatively, Ian, Ian, Stefano - any opinion (as this is formally > living under tools/)? > > Jan >