From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH] adjust x86 EFI build
Date: Tue, 09 Jul 2013 16:20:39 +0100
Message-ID: <CE01E8D7.578FC%keir.xen@gmail.com>
References: <51DC3E5F02000078000E3998@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51DC3E5F02000078000E3998@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 09/07/2013 15:46, "Jan Beulich" <JBeulich@suse.com> wrote:

> While the rule to generate .init.o files from .o ones already correctly
> included $(extra-y), the setting of the necessary compiler flag didn't
> have the same. With some yet to be posted patch this resulted in build
> breakage because of the compiler deciding not to inline a few functions
> (which then results in .text not being empty as required for these
> object files).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -101,7 +101,7 @@ obj-y    := $(patsubst %/,%/built-in.o,$
>  
>  subdir-all := $(subdir-y) $(subdir-n)
>  
> -$(filter %.init.o,$(obj-y) $(obj-bin-y)): CFLAGS += -DINIT_SECTIONS_ONLY
> +$(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS +=
> -DINIT_SECTIONS_ONLY
>  
>  $(obj-$(coverage)): CFLAGS += -fprofile-arcs -ftest-coverage -DTEST_COVERAGE
>  
> 
> 
>