From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86: fix cache flushing condition in map_pages_to_xen()
Date: Wed, 17 Jul 2013 17:31:41 +0100 [thread overview]
Message-ID: <CE0C857D.5876A%keir.xen@gmail.com> (raw)
In-Reply-To: <51E6CFC802000078000E5AB8@nat28.tlf.novell.com>
On 17/07/2013 16:09, "Jan Beulich" <JBeulich@suse.com> wrote:
> This fixes yet another shortcoming of the function (exposed by 8bfaa2c2
> ["x86: add locking to map_pages_to_xen()"]'s adjustment to
> msix_put_fixmap()): It must not flush caches when transitioning to a
> non-present mapping. Doing so causes the CLFLUSH to fault, if used in
> favor of WBINVD.
>
> To help code readability, factor out the whole flush flags updating
> in map_pages_to_xen() into a helper macro.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
I'd prefer the macro modified as I just posted, but either way:
Acked-by: Keir Fraser <keir@xen.org>
next prev parent reply other threads:[~2013-07-17 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 15:09 [PATCH] x86: fix cache flushing condition in map_pages_to_xen() Jan Beulich
2013-07-17 15:40 ` Andrew Cooper
2013-07-17 16:01 ` Jan Beulich
2013-07-17 16:31 ` Keir Fraser
2013-07-18 5:49 ` Jan Beulich
2013-07-18 7:37 ` Keir Fraser
2013-07-17 16:31 ` Keir Fraser [this message]
2013-07-17 20:41 ` Sander Eikelenboom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE0C857D.5876A%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).