From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/MTRR: fix range check in mtrr_add_page()
Date: Tue, 13 Aug 2013 18:34:44 +0100 [thread overview]
Message-ID: <CE302CC4.5AC16%keir.xen@gmail.com> (raw)
In-Reply-To: <520A709D02000078000EB977@nat28.tlf.novell.com>
On 13/08/2013 16:45, "Jan Beulich" <JBeulich@suse.com> wrote:
> Extracted from Yinghai Lu's Linux commit d5c78673 ("x86: Fix /proc/mtrr
> with base/size more than 44bits").
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/cpu/mtrr/main.c
> +++ b/xen/arch/x86/cpu/mtrr/main.c
> @@ -340,7 +340,7 @@ int mtrr_add_page(unsigned long base, un
> return -EINVAL;
> }
>
> - if (base & size_or_mask || size & size_or_mask) {
> + if ((base | (base + size - 1)) >> (paddr_bits - PAGE_SHIFT)) {
> printk(KERN_WARNING "mtrr: base or size exceeds the MTRR width\n");
> return -EINVAL;
> }
>
>
>
prev parent reply other threads:[~2013-08-13 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 15:45 [PATCH] x86/MTRR: fix range check in mtrr_add_page() Jan Beulich
2013-08-13 16:55 ` Andrew Cooper
2013-08-13 17:34 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE302CC4.5AC16%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).