From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH 2/8] sched/arinc653: check for guest data
 transfer failures
Date: Tue, 10 Sep 2013 08:03:01 -0700
Message-ID: <CE5482B5.5D4F0%keir.xen@gmail.com>
References: <1378823662-20803-3-git-send-email-mattjd@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1378823662-20803-3-git-send-email-mattjd@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Matthew Daley <mattjd@gmail.com>, xen-devel@lists.xen.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 10/09/2013 07:34, "Matthew Daley" <mattjd@gmail.com> wrote:

> Coverity-ID: 1055121
> Coverity-ID: 1055122
> Coverity-ID: 1055123
> Coverity-ID: 1055124
> Signed-off-by: Matthew Daley <mattjd@gmail.com>

Acked-by: Keir Fraser <keir@xen.org>

> ---
>  xen/common/sched_arinc653.c |   13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/common/sched_arinc653.c b/xen/common/sched_arinc653.c
> index 63ddb82..2502192 100644
> --- a/xen/common/sched_arinc653.c
> +++ b/xen/common/sched_arinc653.c
> @@ -635,12 +635,21 @@ a653sched_adjust_global(const struct scheduler *ops,
>      switch ( sc->cmd )
>      {
>      case XEN_SYSCTL_SCHEDOP_putinfo:
> -        copy_from_guest(&local_sched, sc->u.sched_arinc653.schedule, 1);
> +        if ( copy_from_guest(&local_sched, sc->u.sched_arinc653.schedule, 1)
> )
> +        {
> +            rc = -EFAULT;
> +            break;
> +        }
> +
>          rc = arinc653_sched_set(ops, &local_sched);
>          break;
>      case XEN_SYSCTL_SCHEDOP_getinfo:
>          rc = arinc653_sched_get(ops, &local_sched);
> -        copy_to_guest(sc->u.sched_arinc653.schedule, &local_sched, 1);
> +        if ( rc )
> +            break;
> +
> +        if ( copy_to_guest(sc->u.sched_arinc653.schedule, &local_sched, 1) )
> +            rc = -EFAULT;
>          break;
>      }
>