xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86: fix memory cut-off when using PFN compression
Date: Wed, 11 Sep 2013 07:04:38 -0700	[thread overview]
Message-ID: <CE55C686.5D88A%keir.xen@gmail.com> (raw)
In-Reply-To: <523082A302000078000F26E0@nat28.tlf.novell.com>

On 11/09/2013 05:48, "Jan Beulich" <JBeulich@suse.com> wrote:

> For one setup_max_pdx(), when invoked a second time (after SRAT got
> parsed), needs to start from the original max_page value again (using
> the already adjusted one from the first invocation would not allow the
> cut-off boundary to be moved up).
> 
> Second, _if_ we need to cut off some part of memory, we must not allow
> this to also propagate into the NUMA accounting. Otherwise
> cutoff_node() results in nodes_cover_memory() to find some parts of
> memory apparently not having a PXM association, causing all SRAT info
> to be ignored.
> 
> The only possibly problematic consumer of node_spanned_pages (the
> meaning of which gets altered here in that it now also includes memory
> Xen can't actively make use of) is XEN_SYSCTL_numainfo: At a first
> glance the potentially larger reported memory size shouldn't confuse
> tool stacks.
> 
> And finally we must not put our boot time modules at addresses which
> (at that time) can't be guaranteed to be accessible later. This applies
> to both the EFI boot loader and the module relocation code.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

      parent reply	other threads:[~2013-09-11 14:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11 12:48 [PATCH] x86: fix memory cut-off when using PFN compression Jan Beulich
2013-09-11 14:02 ` Dario Faggioli
2013-09-11 14:14   ` Jan Beulich
2013-09-11 14:23     ` Dario Faggioli
2013-09-11 14:04 ` Keir Fraser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CE55C686.5D88A%keir.xen@gmail.com \
    --to=keir.xen@gmail.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).