From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] x86: fix memory cut-off when using PFN compression Date: Wed, 11 Sep 2013 07:04:38 -0700 Message-ID: References: <523082A302000078000F26E0@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VJl2F-0001vX-9T for xen-devel@lists.xenproject.org; Wed, 11 Sep 2013 14:04:47 +0000 Received: by mail-pb0-f54.google.com with SMTP id ro12so9166129pbb.27 for ; Wed, 11 Sep 2013 07:04:43 -0700 (PDT) In-Reply-To: <523082A302000078000F26E0@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org On 11/09/2013 05:48, "Jan Beulich" wrote: > For one setup_max_pdx(), when invoked a second time (after SRAT got > parsed), needs to start from the original max_page value again (using > the already adjusted one from the first invocation would not allow the > cut-off boundary to be moved up). > > Second, _if_ we need to cut off some part of memory, we must not allow > this to also propagate into the NUMA accounting. Otherwise > cutoff_node() results in nodes_cover_memory() to find some parts of > memory apparently not having a PXM association, causing all SRAT info > to be ignored. > > The only possibly problematic consumer of node_spanned_pages (the > meaning of which gets altered here in that it now also includes memory > Xen can't actively make use of) is XEN_SYSCTL_numainfo: At a first > glance the potentially larger reported memory size shouldn't confuse > tool stacks. > > And finally we must not put our boot time modules at addresses which > (at that time) can't be guaranteed to be accessible later. This applies > to both the EFI boot loader and the module relocation code. > > Signed-off-by: Jan Beulich Acked-by: Keir Fraser