xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.xen@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] xen/build: Remove hacked up version of figlet
Date: Thu, 12 Sep 2013 09:30:37 -0700	[thread overview]
Message-ID: <CE573A3D.5DB4E%keir.xen@gmail.com> (raw)
In-Reply-To: <1379001104-21867-1-git-send-email-andrew.cooper3@citrix.com>

On 12/09/2013 08:51, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:

> This hacked up version of figlet contributes a supprisingly large proportion
> of the Coverity issues found under xen/ (and therefore attributed against Xen)
> 
> Figlet can be found in all distros, so make use of it.
> 
> We keep xen.flf (being the Xen figlet font) and replace the hacked up octal
> transform with a short python script.
> 
> The Xen Makefile has been tweaked in such a way that it still prints the
> figlet banner for the build.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Tim Deegan <tim@xen.org>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Keir Fraser <keir@xen.org>

  parent reply	other threads:[~2013-09-12 16:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-12 15:51 [PATCH] xen/build: Remove hacked up version of figlet Andrew Cooper
2013-09-12 16:27 ` Ian Campbell
2013-09-12 16:31   ` Andrew Cooper
2013-09-12 16:30 ` Keir Fraser [this message]
2013-09-13  9:14 ` Jan Beulich
2013-09-13  9:30   ` Ian Campbell
2013-09-13  9:40     ` Jan Beulich
2013-09-13  9:46       ` Ian Campbell
2013-09-13 10:16         ` Ian Jackson
2013-09-26 15:46           ` Andrew Cooper
2013-10-11 17:59             ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CE573A3D.5DB4E%keir.xen@gmail.com \
    --to=keir.xen@gmail.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).