From: Keir Fraser <keir.xen@gmail.com>
To: Tim Deegan <tim@xen.org>
Cc: jbeulich@suse.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] x86: mark BUG()s and assertion failures as terminal.
Date: Thu, 19 Sep 2013 16:17:12 +0100 [thread overview]
Message-ID: <CE60D408.33DB3%keir.xen@gmail.com> (raw)
In-Reply-To: <20130919151043.GL52431@ocelot.phlegethon.org>
On 19/09/2013 16:10, "Tim Deegan" <tim@xen.org> wrote:
> At 16:07 +0100 on 19 Sep (1379606849), Tim Deegan wrote:
>> At 15:56 +0100 on 19 Sep (1379606210), Keir Fraser wrote:
>>> On 19/09/2013 15:39, "Tim Deegan" <tim@xen.org> wrote:
>>>> @@ -14,6 +14,12 @@
>>>> #define always_inline __inline__ __attribute__ ((always_inline))
>>>> #define noinline __attribute__((noinline))
>>>>
>>>> +#if (!defined(__clang__) && (__GNUC__ == 4) && (__GNUC_MINOR__ < 5))
>>>
>>> Do you mean for gcc-3.4 to use __builtin_unreachable()?
>>
>> No, what I want is for clang and all GCCs >= 4.5 to use the builtin.
>
> Oh wait, I understand your question now: gcc 3.4 will already have
> failed the version check at the top of the file, so I don't need to
> check for it here.
Argh, I was looking at a 4.1 branch. :)
Then my Ack applies to your original patch as is!
-- Keir
> Tim.
next prev parent reply other threads:[~2013-09-19 15:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 14:39 [PATCH] x86: mark BUG()s and assertion failures as terminal Tim Deegan
2013-09-19 14:56 ` Keir Fraser
2013-09-19 15:07 ` Tim Deegan
2013-09-19 15:10 ` Tim Deegan
2013-09-19 15:17 ` Keir Fraser [this message]
2013-09-19 15:13 ` Keir Fraser
2013-09-19 15:44 ` Andrew Cooper
2013-09-19 16:52 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE60D408.33DB3%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=jbeulich@suse.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).