From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 0/6] x86: emulation improvements
Date: Fri, 20 Sep 2013 10:10:13 +0100 [thread overview]
Message-ID: <CE61CF85.33EA8%keir.xen@gmail.com> (raw)
In-Reply-To: <523C21BB02000078000F4D6D@nat28.tlf.novell.com>
On 20/09/2013 09:21, "Jan Beulich" <JBeulich@suse.com> wrote:
>>>> On 19.09.13 at 18:12, Keir Fraser <keir.xen@gmail.com> wrote:
>> On 19/09/2013 16:40, "Jan Beulich" <JBeulich@suse.com> wrote:
>>
>>> 1: x86/HVM: properly handle MMIO reads and writes wider than a machine word
>>> 2: x86: fix dependencies of emulator test
>>> 3: x86_emulate: MOVSXD must read source operand just once
>>> 4: x86_emulate: PUSH <mem> must read source operand just once
>>> 5: x86_emulate: fix flag setting for 8-bit signed multiplication
>>> 6: x86_emulate: fold wide reads
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> Nice.
>>
>> Acked-by: Keir Fraser <keir@xen.org>
>
> I'm going to commit them with two tiny adjustments:
>
> In the first patch I simplified the initializer of "chunk" to
>
> chunk = min(bytes, 1U << LONG_BYTEORDER)
>
> And in the fourth patch I replaced the newly added conditional in
> the 8-bit case with an ASSERT() (which in turn requires the test
> utility to be adjusted to have ASSERT() available).
>
> I'm sure you're fine with both.
Yes, fine!
-- Keir
> There's going to be one more, fixing wrap around handling for
> repeated string instructions; need to still give this some minimal
> testing before submitting.
>
> Jan
>
prev parent reply other threads:[~2013-09-20 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 15:40 [PATCH 0/6] x86: emulation improvements Jan Beulich
2013-09-19 15:42 ` [PATCH 1/6] x86/HVM: properly handle MMIO reads and writes wider than a machine word Jan Beulich
2013-09-19 15:43 ` [PATCH 2/6] x86: fix dependencies of emulator test Jan Beulich
2013-09-19 15:44 ` [PATCH 3/6] x86_emulate: MOVSXD must read source operand just once Jan Beulich
2013-09-19 15:44 ` [PATCH 4/6] x86_emulate: PUSH <mem> " Jan Beulich
2013-09-19 15:45 ` [PATCH 5/6] x86_emulate: fix flag setting for 8-bit signed multiplication Jan Beulich
2013-09-19 15:46 ` [PATCH 6/6] x86_emulate: fold wide reads Jan Beulich
2013-09-19 16:12 ` [PATCH 0/6] x86: emulation improvements Keir Fraser
2013-09-20 8:21 ` Jan Beulich
2013-09-20 9:10 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE61CF85.33EA8%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).