From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH 0/6] x86: emulation improvements
Date: Fri, 20 Sep 2013 10:10:13 +0100
Message-ID: <CE61CF85.33EA8%keir.xen@gmail.com>
References: <523C21BB02000078000F4D6D@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <keir.xen@gmail.com>) id 1VMwjK-0000td-9K
	for xen-devel@lists.xenproject.org; Fri, 20 Sep 2013 09:10:26 +0000
Received: by mail-we0-f178.google.com with SMTP id u57so190095wes.9
	for <xen-devel@lists.xenproject.org>;
	Fri, 20 Sep 2013 02:10:24 -0700 (PDT)
In-Reply-To: <523C21BB02000078000F4D6D@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On 20/09/2013 09:21, "Jan Beulich" <JBeulich@suse.com> wrote:

>>>> On 19.09.13 at 18:12, Keir Fraser <keir.xen@gmail.com> wrote:
>> On 19/09/2013 16:40, "Jan Beulich" <JBeulich@suse.com> wrote:
>> 
>>> 1: x86/HVM: properly handle MMIO reads and writes wider than a machine word
>>> 2: x86: fix dependencies of emulator test
>>> 3: x86_emulate: MOVSXD must read source operand just once
>>> 4: x86_emulate: PUSH <mem> must read source operand just once
>>> 5: x86_emulate: fix flag setting for 8-bit signed multiplication
>>> 6: x86_emulate: fold wide reads
>>> 
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> 
>> Nice.
>> 
>> Acked-by: Keir Fraser <keir@xen.org>
> 
> I'm going to commit them with two tiny adjustments:
> 
> In the first patch I simplified the initializer of "chunk" to
> 
> chunk = min(bytes, 1U << LONG_BYTEORDER)
> 
> And in the fourth patch I replaced the newly added conditional in
> the 8-bit case with an ASSERT() (which in turn requires the test
> utility to be adjusted to have ASSERT() available).
> 
> I'm sure you're fine with both.

Yes, fine!

 -- Keir

> There's going to be one more, fixing wrap around handling for
> repeated string instructions; need to still give this some minimal
> testing before submitting.
> 
> Jan
>