From: Keir Fraser <keir.xen@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: Tim Deegan <tim@xen.org>, Jan Beulich <JBeulich@suse.com>
Subject: Re: [Patch] hvm/vidirian: Avoid printing page_to_mfn(NULL) on error paths.
Date: Wed, 09 Oct 2013 06:26:32 +0100 [thread overview]
Message-ID: <CE7AA798.5F916%keir.xen@gmail.com> (raw)
In-Reply-To: <1381263454-28115-1-git-send-email-andrew.cooper3@citrix.com>
On 08/10/2013 21:17, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:
> While working in the viridian code, I noticed that 4cb6c4f4941
>
> "x86/hvm: Use get_page_from_gfn() instead of get_gfn()/put_gfn."
>
> introduced two error paths where page_to_mfn(NULL) would be formatted and
> presented as a bad MFN. This provides junk in the warning rather than
> something useful.
>
> These two codepaths are fixed up to match their counterpart in
> wrmsr_hypervisor_regs()
>
> While auditing the other changes from 4cb6c4f4941, I noticed a small
> optimisation which could be made by changing the order of the validity checks
> to remove 6 NULL pointer checks.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Tim Deegan <tim@xen.org>
Acked-by: Keir Fraser <keir@xen.org>
next prev parent reply other threads:[~2013-10-09 5:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 20:17 [Patch] hvm/vidirian: Avoid printing page_to_mfn(NULL) on error paths Andrew Cooper
2013-10-09 5:26 ` Keir Fraser [this message]
2013-10-09 9:08 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE7AA798.5F916%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).