From: Keir Fraser <keir.xen@gmail.com>
To: Tim Deegan <tim@xen.org>, Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] common/sched: Correct function prototypes
Date: Fri, 11 Oct 2013 14:54:34 +0100 [thread overview]
Message-ID: <CE7DC1AA.390B8%keir.xen@gmail.com> (raw)
In-Reply-To: <20131011120656.GA90538@ocelot.phlegethon.org>
On 11/10/2013 13:06, "Tim Deegan" <tim@xen.org> wrote:
>>>> ... I'd much prefer if we stopped naming parameters in declarations
>>>> where the parameter types are already sufficiently describing them.
>>>
>>> I'd rather not -- I prefer the declarations to match the definitions.
>>
>> Any specific reason for that?
>
> Nothing very strong -- I just find it easier to read, and more
> consistent (since we do need to keep the names of _some_ arguments).
>
> I know there are lots of type-only declarations in the tree already, and
> I'm not suggesting we get rid of them, but I wouldn't like to see it
> become the prescribed coding style.
I agree with this.
-- Keir
next prev parent reply other threads:[~2013-10-11 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 17:05 [PATCH] common/sched: Correct function prototypes Andrew Cooper
2013-10-10 18:25 ` Keir Fraser
2013-10-11 6:55 ` Jan Beulich
2013-10-11 9:40 ` Tim Deegan
2013-10-11 11:49 ` Jan Beulich
2013-10-11 12:06 ` Tim Deegan
2013-10-11 13:54 ` Keir Fraser [this message]
2013-10-11 14:47 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE7DC1AA.390B8%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).