From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 0/3] irqsave/restore improvements Date: Mon, 21 Oct 2013 15:08:20 +0100 Message-ID: References: <1382362893-12603-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1382362893-12603-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Xen-devel Cc: George Dunlap , Tim Deegan , Stefano Stabellini , Ian Campbell , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 21/10/2013 14:41, "Andrew Cooper" wrote: > This series contains two independent but related fixes to do with > irqsave/restore semantics. > > The first patch prevents local_irq_restore() from corrupting system flags. > > The second was constructed using the compile errors from the third patch, > separated for clarity and reordered to prevent bisection problems. > > The third patch uses a BUILD_BUG_ON() to ensure that the flags parameter to > spin_lock_irqsave is wide enough to not trucate the result from > local_irq_save(). > > I have not compile tested on arm, so request that one of the maintainers > explicitly acks the final patch. Any compile failures will almost certainly > be fixed with an int->unsigned long conversion on the affected variable(s). > > Signed-off-by: Andrew Cooper > CC: Keir Fraser > CC: Jan Beulich > CC: Ian Campbell > CC: Stefano Stabellini > CC: Tim Deegan > CC: George Dunlap Acked-by: Keir Fraser > -- > 1.7.10.4 >