xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.xen@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
	Keir Fraser <keir@xen.org>,
	Nathan Studer <nate.studer@dornerworks.com>,
	xen-devel@lists.xen.org
Subject: Re: [Patch] Call sched_destroy_domain before cpupool_rm_domain.
Date: Tue, 05 Nov 2013 21:09:03 +0000	[thread overview]
Message-ID: <CE9F0EEF.3D20A%keir.xen@gmail.com> (raw)
In-Reply-To: <52776A00.5030702@citrix.com>

On 04/11/2013 09:33, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:

> On 04/11/13 06:30, Juergen Gross wrote:
>> On 04.11.2013 04:03, Nathan Studer wrote:
>>> From: Nathan Studer <nate.studer@dornerworks.com>
>>> 
>>> The domain destruction code, removes a domain from its cpupool
>>> before attempting to destroy its scheduler information.  Since
>>> the scheduler framework uses the domain's cpupool information
>>> to decide on which scheduler ops to use, this results in the
>>> the wrong scheduler's destroy domain function being called
>>> when the cpupool scheduler and the initial scheduler are
>>> different.
>>> 
>>> Correct this by destroying the domain's scheduling information
>>> before removing it from the pool.
>>> 
>>> Signed-off-by: Nathan Studer <nate.studer@dornerworks.com>
>> 
>> Reviewed-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Keir Fraser <keir@xen.org>

  reply	other threads:[~2013-11-05 21:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04  3:03 [Patch] Call sched_destroy_domain before cpupool_rm_domain Nathan Studer
2013-11-04  6:30 ` Juergen Gross
2013-11-04  9:26   ` Dario Faggioli
2013-11-04  9:58     ` Juergen Gross
2013-11-04 15:22       ` Nate Studer
2013-11-05  5:59         ` Juergen Gross
2013-11-07  7:39           ` Jan Beulich
2013-11-07  9:09             ` Juergen Gross
2013-11-07  9:37               ` Jan Beulich
2013-11-07  9:43                 ` Juergen Gross
2013-11-04  9:33   ` Andrew Cooper
2013-11-05 21:09     ` Keir Fraser [this message]
2013-11-04 15:10 ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CE9F0EEF.3D20A%keir.xen@gmail.com \
    --to=keir.xen@gmail.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=juergen.gross@ts.fujitsu.com \
    --cc=keir@xen.org \
    --cc=nate.studer@dornerworks.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).