xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Jinsong Liu <jinsong.liu@intel.com>,
	Jun Nakajima <jun.nakajima@intel.com>
Subject: Re: [PATCH] x86/Intel: don't probe CPUID faulting on family 0xf CPUs
Date: Mon, 11 Nov 2013 09:41:00 +0000	[thread overview]
Message-ID: <CEA656AC.3DB95%keir.xen@gmail.com> (raw)
In-Reply-To: <52809F870200007800101A09@nat28.tlf.novell.com>

On 11/11/2013 08:12, "Jan Beulich" <JBeulich@suse.com> wrote:

> These are known to not support the feature, so we can save ourselves
> from emitting the resulting #GP fault recovery related message (which
> might worry people looking at the logs).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -204,7 +204,7 @@ static void __devinit init_intel(struct
> detect_ht(c);
> }
>  
> - if (smp_processor_id() == 0) {
> + if (c == &boot_cpu_data && c->x86 == 6) {
> if (probe_intel_cpuid_faulting())
> set_bit(X86_FEATURE_CPUID_FAULTING, c->x86_capability);
> } else if (boot_cpu_has(X86_FEATURE_CPUID_FAULTING)) {
> 
> 
> 

      parent reply	other threads:[~2013-11-11  9:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11  8:12 [PATCH] x86/Intel: don't probe CPUID faulting on family 0xf CPUs Jan Beulich
2013-11-11  9:27 ` Liu, Jinsong
2013-11-11  9:41 ` Keir Fraser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CEA656AC.3DB95%keir.xen@gmail.com \
    --to=keir.xen@gmail.com \
    --cc=JBeulich@suse.com \
    --cc=jinsong.liu@intel.com \
    --cc=jun.nakajima@intel.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).