* [PATCH] x86/Intel: don't probe CPUID faulting on family 0xf CPUs
@ 2013-11-11 8:12 Jan Beulich
2013-11-11 9:27 ` Liu, Jinsong
2013-11-11 9:41 ` Keir Fraser
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2013-11-11 8:12 UTC (permalink / raw)
To: xen-devel; +Cc: Jinsong Liu, Keir Fraser, Jun Nakajima
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
These are known to not support the feature, so we can save ourselves
from emitting the resulting #GP fault recovery related message (which
might worry people looking at the logs).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/cpu/intel.c
+++ b/xen/arch/x86/cpu/intel.c
@@ -204,7 +204,7 @@ static void __devinit init_intel(struct
detect_ht(c);
}
- if (smp_processor_id() == 0) {
+ if (c == &boot_cpu_data && c->x86 == 6) {
if (probe_intel_cpuid_faulting())
set_bit(X86_FEATURE_CPUID_FAULTING, c->x86_capability);
} else if (boot_cpu_has(X86_FEATURE_CPUID_FAULTING)) {
[-- Attachment #2: x86-CPUID-faulting-skip-FamF.patch --]
[-- Type: text/plain, Size: 683 bytes --]
x86/Intel: don't probe CPUID faulting on family 0xf CPUs
These are known to not support the feature, so we can save ourselves
from emitting the resulting #GP fault recovery related message (which
might worry people looking at the logs).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/cpu/intel.c
+++ b/xen/arch/x86/cpu/intel.c
@@ -204,7 +204,7 @@ static void __devinit init_intel(struct
detect_ht(c);
}
- if (smp_processor_id() == 0) {
+ if (c == &boot_cpu_data && c->x86 == 6) {
if (probe_intel_cpuid_faulting())
set_bit(X86_FEATURE_CPUID_FAULTING, c->x86_capability);
} else if (boot_cpu_has(X86_FEATURE_CPUID_FAULTING)) {
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86/Intel: don't probe CPUID faulting on family 0xf CPUs
2013-11-11 8:12 [PATCH] x86/Intel: don't probe CPUID faulting on family 0xf CPUs Jan Beulich
@ 2013-11-11 9:27 ` Liu, Jinsong
2013-11-11 9:41 ` Keir Fraser
1 sibling, 0 replies; 3+ messages in thread
From: Liu, Jinsong @ 2013-11-11 9:27 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Keir Fraser, Nakajima, Jun
Jan Beulich wrote:
> These are known to not support the feature, so we can save ourselves
> from emitting the resulting #GP fault recovery related message (which
> might worry people looking at the logs).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -204,7 +204,7 @@ static void __devinit init_intel(struct
> detect_ht(c);
> }
>
> - if (smp_processor_id() == 0) {
> + if (c == &boot_cpu_data && c->x86 == 6) {
> if (probe_intel_cpuid_faulting())
> set_bit(X86_FEATURE_CPUID_FAULTING, c->x86_capability);
> } else if (boot_cpu_has(X86_FEATURE_CPUID_FAULTING)) {
Acked-by: Liu Jinsong <jinsong.liu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86/Intel: don't probe CPUID faulting on family 0xf CPUs
2013-11-11 8:12 [PATCH] x86/Intel: don't probe CPUID faulting on family 0xf CPUs Jan Beulich
2013-11-11 9:27 ` Liu, Jinsong
@ 2013-11-11 9:41 ` Keir Fraser
1 sibling, 0 replies; 3+ messages in thread
From: Keir Fraser @ 2013-11-11 9:41 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Jinsong Liu, Jun Nakajima
On 11/11/2013 08:12, "Jan Beulich" <JBeulich@suse.com> wrote:
> These are known to not support the feature, so we can save ourselves
> from emitting the resulting #GP fault recovery related message (which
> might worry people looking at the logs).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -204,7 +204,7 @@ static void __devinit init_intel(struct
> detect_ht(c);
> }
>
> - if (smp_processor_id() == 0) {
> + if (c == &boot_cpu_data && c->x86 == 6) {
> if (probe_intel_cpuid_faulting())
> set_bit(X86_FEATURE_CPUID_FAULTING, c->x86_capability);
> } else if (boot_cpu_has(X86_FEATURE_CPUID_FAULTING)) {
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-11 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-11 8:12 [PATCH] x86/Intel: don't probe CPUID faulting on family 0xf CPUs Jan Beulich
2013-11-11 9:27 ` Liu, Jinsong
2013-11-11 9:41 ` Keir Fraser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).