From: Keir Fraser <keir.xen@gmail.com>
To: Julien Grall <julien.grall@linaro.org>, xen-devel@lists.xenproject.org
Cc: patches@linaro.org, tim@xen.org, ian.campbell@citrix.com,
Jan Beulich <jbeulich@suse.com>,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH V3] xen: Check if the range is valid in init_domheap_pages
Date: Wed, 13 Nov 2013 14:58:20 +0000 [thread overview]
Message-ID: <CEA9440C.64E5F%keir.xen@gmail.com> (raw)
In-Reply-To: <1384349870-4256-1-git-send-email-julien.grall@linaro.org>
On 13/11/2013 13:37, "Julien Grall" <julien.grall@linaro.org> wrote:
> On ARM, when an initrd is given to xen by U-boot, it will reserve the memory
> in
> the device tree.
> In this case, when xen decides to free unused memory, dt_unreserved_regions
> will call init_domheap_pages with the start and the end of range equals. But
> the latter assumes that (start > end), if not Xen will hang because the
> number of pages is equals to (unsigned)-1.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <jbeulich@suse.com>
I understand Jan's reservations, but I think just being more liberal here is
fine really.
Acked-by: Keir Fraser <keir@xen.org>
next prev parent reply other threads:[~2013-11-13 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 13:37 [PATCH V3] xen: Check if the range is valid in init_domheap_pages Julien Grall
2013-11-13 14:58 ` Keir Fraser [this message]
2013-11-20 16:09 ` Julien Grall
2013-11-20 21:12 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CEA9440C.64E5F%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@linaro.org \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).