From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] VT-d: fix TLB flushing in dma_pte_clear_one() Date: Mon, 18 Nov 2013 03:58:25 -0800 Message-ID: References: <528A06C90200007800103FA4@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ViNTQ-0008Gc-2b for xen-devel@lists.xenproject.org; Mon, 18 Nov 2013 11:58:36 +0000 Received: by mail-pa0-f41.google.com with SMTP id bj1so1640810pad.14 for ; Mon, 18 Nov 2013 03:58:32 -0800 (PST) In-Reply-To: <528A06C90200007800103FA4@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: "junqing@pku.edu.cn" , CHENG Yueqiang , "zhangzhi2022@hotmail.com" , xiantao.zhang@intel.com List-Id: xen-devel@lists.xenproject.org On 18/11/2013 03:23, "Jan Beulich" wrote: > The third parameter of __intel_iommu_iotlb_flush() is to indicate > whether the to be flushed entry was a present one. A few lines before, > we bailed if !dma_pte_present(*pte), so there's no need to check the > flag here again - we can simply always pass TRUE here. > > This is XSA-78. > > Suggested-by: Cheng Yueqiang > Signed-off-by: Jan Beulich Acked-by: Keir Fraser > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -646,7 +646,7 @@ static void dma_pte_clear_one(struct dom > iommu_flush_cache_entry(pte, sizeof(struct dma_pte)); > > if ( !this_cpu(iommu_dont_flush_iotlb) ) > - __intel_iommu_iotlb_flush(domain, addr >> PAGE_SHIFT_4K , 0, 1); > + __intel_iommu_iotlb_flush(domain, addr >> PAGE_SHIFT_4K, 1, 1); > > unmap_vtd_domain_page(page); > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel