From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [Patch v3 0/4] Xen stack trace printing improvements Date: Tue, 19 Nov 2013 08:07:25 -0800 Message-ID: References: <528B4520.1060905@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <528B4520.1060905@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap , Andrew Cooper Cc: Tim Deegan , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org On 19/11/2013 03:01, "George Dunlap" wrote: > On 11/19/2013 10:50 AM, Andrew Cooper wrote: >> On 19/11/2013 10:10, George Dunlap wrote: >> Benefits: >> * Use frame pointers in the stack overflow case >> * Correct boundaries for frame pointer traces >> * Wild function pointer semantics in the common case now >> >> Risks: >> * Issues with printing stack traces (although if you notice, I haven't >> actually changed either of the printing algorithms) >> >> This series seemed accepted-in-principle at v1 ages ago, pending me >> confirming the boundaries. (which have admittedly be tweaked in this >> latest series). > > That makes more sense, thanks. If Jan and/or Keir see it that way, then > the series is fine with me f/ a release perspective. Yes, this series should go in. -- Keir > -George