From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH V3] xen: Check if the range is valid in init_domheap_pages Date: Wed, 20 Nov 2013 13:12:00 -0800 Message-ID: References: <528CDEBD.8060508@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VjF4K-0003kW-DA for xen-devel@lists.xenproject.org; Wed, 20 Nov 2013 21:12:16 +0000 Received: by mail-pb0-f41.google.com with SMTP id jt11so10548865pbb.0 for ; Wed, 20 Nov 2013 13:12:12 -0800 (PST) In-Reply-To: <528CDEBD.8060508@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , Julien Grall Cc: ian.campbell@citrix.com, patches@linaro.org, stefano.stabellini@eu.citrix.com, tim@xen.org, Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 20/11/2013 08:09, "Julien Grall" wrote: > On 11/13/2013 01:37 PM, Julien Grall wrote: >> On ARM, when an initrd is given to xen by U-boot, it will reserve the memory >> in >> the device tree. >> In this case, when xen decides to free unused memory, dt_unreserved_regions >> will call init_domheap_pages with the start and the end of range equals. But >> the latter assumes that (start > end), if not Xen will hang because the >> number of pages is equals to (unsigned)-1. >> >> Signed-off-by: Julien Grall >> CC: Keir Fraser >> CC: Jan Beulich > > Ping ? Without this commit, the user is unable to pass initrd to dom0 on > ARM. It was fine with me. Acked-by: Keir Fraser