From: Keir Fraser <keir.xen@gmail.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Keir Fraser <keir@xen.org>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [Patch v3 0/2] Remove figlet from the source tree
Date: Fri, 29 Nov 2013 20:15:14 +0000 [thread overview]
Message-ID: <CEBEA652.41F6B%keir.xen@gmail.com> (raw)
In-Reply-To: <1385721828.25763.8.camel@kazak.uk.xensource.com>
On 29/11/2013 10:43, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:
> On Mon, 2013-11-25 at 19:45 +0000, Keir Fraser wrote:
>> On 25/11/2013 14:38, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:
>>
>>> Ian Campbell writes ("Re: [Xen-devel] [Patch v3 0/2] Remove figlet from the
>>> source tree"):
>>>> It doesn't quite disappear it is just printed as normal ASCII text
>>>> instead.
>>>>
>>>> We could include a static "Xen" banner figlet output and just print the
>>>> version in normal ASCII text. Or we could check in the figlet banner and
>>>> make it part of the release process to update it (liable to forgetting
>>>> though, so I'm not in favour of this).
>>>
>>> I far prefer the approach in Andrew's patch.
>>
>> Personally I think we should just get rid of the banner entirely.
>
> In the absence of such a patch I think Andrew's series is a step in the
> right direction.
>
> Any objections to me merging it?
Not from me.
-- Keir
> Ian.
>
next prev parent reply other threads:[~2013-11-29 20:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 11:00 [Patch v3 0/2] Remove figlet from the source tree Andrew Cooper
2013-11-25 11:00 ` [Patch v3 1/2] xen/build: Use a distro version of figlet Andrew Cooper
2013-11-25 11:21 ` [Patch v3 0/2] Remove figlet from the source tree Ian Campbell
2013-11-25 11:23 ` Andrew Cooper
2013-11-25 12:21 ` George Dunlap
2013-11-25 12:25 ` Ian Campbell
2013-11-25 14:38 ` Ian Jackson
2013-11-25 19:45 ` Keir Fraser
2013-11-26 1:25 ` Matthew Daley
2013-11-26 8:35 ` Ian Campbell
2013-11-29 10:43 ` Ian Campbell
2013-11-29 20:15 ` Keir Fraser [this message]
2013-12-02 14:11 ` Ian Campbell
2013-11-25 14:38 ` Ian Jackson
2013-11-25 14:41 ` George Dunlap
2013-11-25 16:35 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CEBEA652.41F6B%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).