From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH] common/vsprintf: fix return value when
 formatting symbolic addresses
Date: Mon, 02 Dec 2013 15:23:36 +0000
Message-ID: <CEC25678.683EA%keir.xen@gmail.com>
References: <529C8611.6060301@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <keir.xen@gmail.com>) id 1VnVLf-0006Ym-Kf
	for xen-devel@lists.xenproject.org; Mon, 02 Dec 2013 15:23:47 +0000
Received: by mail-ea0-f173.google.com with SMTP id g15so9171627eak.18
	for <xen-devel@lists.xenproject.org>;
	Mon, 02 Dec 2013 07:23:46 -0800 (PST)
In-Reply-To: <529C8611.6060301@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On 02/12/2013 13:07, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:

> On 02/12/13 12:06, Jan Beulich wrote:
>> When the buffer to be formatted to is too small, the function return
>> value is expected to be the number of characters that would be printed
>> (particularly important if that value is then used for allocating a
>> buffer). Hence incrementing the active pointer must always be
>> independent of actually storing a character.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Keir Fraser <keir@xen.org>

>> 
>> --- a/xen/common/vsprintf.c
>> +++ b/xen/common/vsprintf.c
>> @@ -294,6 +294,7 @@ static char *pointer(char *str, char *en
>>              /* Print '+<offset>/<len>' */
>>              str = number(str, end, sym_offset, 16, -1, -1,
>> SPECIAL|SIGN|PLUS);
>>              if ( str <= end )
>> -                *str++ = '/';
>> +                *str = '/';
>> +            ++str;
>>              str = number(str, end, sym_size, 16, -1, -1, SPECIAL);
>>          }
>>  
>> 
>> 
>> 
> 
>