From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH 2/2] xen/page_alloc: Defer the domain
 mapping in scrub_one_page()
Date: Mon, 09 Dec 2013 11:02:17 +0000
Message-ID: <CECB53B9.699A4%keir.xen@gmail.com>
References: <52A5A4F8020000780010B4DC@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <keir.xen@gmail.com>) id 1VpybZ-0006ec-1z
	for xen-devel@lists.xenproject.org; Mon, 09 Dec 2013 11:02:25 +0000
Received: by mail-wi0-f182.google.com with SMTP id en1so3492346wid.15
	for <xen-devel@lists.xenproject.org>;
	Mon, 09 Dec 2013 03:02:23 -0800 (PST)
In-Reply-To: <52A5A4F8020000780010B4DC@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Tim Deegan <tim@xen.org>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On 09/12/2013 10:09, "Jan Beulich" <JBeulich@suse.com> wrote:

>>>> On 04.12.13 at 16:09, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> This avoids a resource leak and needless playing with the pagetables in the
>> case that the page is broken.
>> 
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> CC: Keir Fraser <keir@xen.org>
> 
> Keir?

Reviewed-by: Keir Fraser <keir@xen.org>

>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Tim Deegan <tim@xen.org>
>> ---
>>  xen/common/page_alloc.c |    4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
>> index 8002bd2..5f484a2 100644
>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -1652,11 +1652,13 @@ __initcall(pagealloc_keyhandler_init);
>>  
>>  void scrub_one_page(struct page_info *pg)
>>  {
>> -    void *p = __map_domain_page(pg);
>> +    void *p;
>>  
>>      if ( unlikely(pg->count_info & PGC_broken) )
>>          return;
>>  
>> +    p = __map_domain_page(pg);
>> +
>>  #ifndef NDEBUG
>>      /* Avoid callers relying on allocations returning zeroed pages. */
>>      memset(p, 0xc2, PAGE_SIZE);
>> -- 
>> 1.7.10.4
> 
> 
>