From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars Kurth Subject: Re: [PATCH] xen/tools: Introduce QNX IFS loader Date: Wed, 20 Aug 2014 04:09:00 +0000 Message-ID: References: <1408463462-19568-1-git-send-email-oleksandr.tyshchenko@globallogic.com> <53F3778E.4020109@citrix.com> <1408465606.3725.53.camel@Solace.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1408465606.3725.53.camel@Solace.lan> Content-Language: en-US Content-ID: <0A22C2D3AAA69445A462036869726382@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli , Andrew Cooper Cc: Ian Campbell , Brian Warner , "julien.grall@linaro.org" , "Tim (Xen.org)" , "xen-devel@lists.xen.org" , Oleksandr Tyshchenko , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 19/08/2014 11:26, "Dario Faggioli" wrote: >[Adding Lars, as he may be of help with licensing things] > >On mar, 2014-08-19 at 17:13 +0100, Andrew Cooper wrote: >> On 19/08/14 16:51, Oleksandr Tyshchenko wrote: >> > Add ability to load QNX IFS image. Based on IPL code (U-Boot for QNX). >> > >> > Signed-off-by: Oleksandr Tyshchenko >> >> > --- >> > tools/libxc/Makefile | 1 + >> > tools/libxc/xc_dom_qnxifsloader.c | 189 >>++++++++++++++++++++++++++++++++++++++ >> > 2 files changed, 190 insertions(+) >> > create mode 100644 tools/libxc/xc_dom_qnxifsloader.c >> > >> > diff --git a/tools/libxc/Makefile b/tools/libxc/Makefile >> > index 22eef8e..812cc7e 100644 >> > --- a/tools/libxc/Makefile >> > +++ b/tools/libxc/Makefile >> > @@ -67,6 +67,7 @@ GUEST_SRCS-y +=3D xc_dom_elfloader.c >> > GUEST_SRCS-$(CONFIG_X86) +=3D xc_dom_bzimageloader.c >> > GUEST_SRCS-$(CONFIG_X86) +=3D xc_dom_decompress_lz4.c >> > GUEST_SRCS-$(CONFIG_ARM) +=3D xc_dom_armzimageloader.c >> > +GUEST_SRCS-$(CONFIG_ARM) +=3D xc_dom_qnxifsloader.c >> > GUEST_SRCS-y +=3D xc_dom_binloader.c >> > GUEST_SRCS-y +=3D xc_dom_compat_linux.c >> > = >> > diff --git a/tools/libxc/xc_dom_qnxifsloader.c >>b/tools/libxc/xc_dom_qnxifsloader.c >> > new file mode 100644 >> > index 0000000..45d007d >> > --- /dev/null >> > +++ b/tools/libxc/xc_dom_qnxifsloader.c >> > @@ -0,0 +1,189 @@ >> > +/* >> > + * Xen domain builder -- QNX IFS bits >> > + * >> > + * Parse and load QNX IFS image. >> > + * >> > + * Copyright (C) 2014, Globallogic. >> > + * >> > + * Licensed under the Apache License, Version 2.0 (the "License"). >>You >> > + * may not reproduce, modify or distribute this software except in >> > + * compliance with the License. You may obtain a copy of the License >> > + * at: http://www.apache.org/licenses/LICENSE-2.0 >> > + * >> > + * Unless required by applicable law or agreed to in writing, >>software >> > + * distributed under the License is distributed on an "AS IS" basis, >> > + * WITHOUT WARRANTIES OF ANY KIND, either express or implied. >> > + * >> > + * This file may contain contributions from others, either as >> > + * contributors under the License or as licensors under other terms. >> > + * Please review this entire file for other proprietary rights or >>license >> > + * notices, as well as the QNX Development Suite License Guide at >> > + * http://licensing.qnx.com/license-guide/ for other information. >> > + */ >> = >> The rest of libxc is licensed under GPLv2.1, which is incompatible with >> Apache 2.0 That is correct. = The question is whether this code needs to be Apache 2.0. My understanding was that the QNX recommendation is that a base port of QNX (aka the drivers) are recommended to be Apache 2. But it is not clear to me whether the boot loader needs to be. I don=B9t have enough context and can=B9t find any reference to the file system itself in the license guide. I do not know enough about the subtleties of licenses here and am adding Brian, in case we need to get some more advice on how to mitigate this issue. @Oleksandr, can you also check with your legal guys? Regards Lars