From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v8 0/6] xen: systemd support
Date: Thu, 31 Jul 2014 09:30:49 +0100
Message-ID: <E1XCllH-0006mx-Iq@lists.xen.org>
References: <1406340860-8547-1-git-send-email-mcgrof@do-not-panic.com>
	<1406551592.14628.15.camel@kazak.uk.xensource.com>
	<20140728150215.GA21930@wotan.suse.de>
	<1406559951.16498.6.camel@kazak.uk.xensource.com>
	<20140728175719.GH21930@wotan.suse.de>
	<1406624199.20809.9.camel@kazak.uk.xensource.com>
	<20140730162213.GV21930@wotan.suse.de>
	<1406737540.29218.1.camel@kazak.uk.xensource.com>
	<20140730164338.GW21930@wotan.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XCllG-0006mr-2a
	for xen-devel@lists.xenproject.org; Thu, 31 Jul 2014 08:30:54 +0000
In-Reply-To: <20140730164338.GW21930@wotan.suse.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: xen-devel@lists.xenproject.org, "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-07-30 at 18:43 +0200, Luis R. Rodriguez wrote:
> On Wed, Jul 30, 2014 at 05:25:40PM +0100, Ian Campbell wrote:
> > On Wed, 2014-07-30 at 18:22 +0200, Luis R. Rodriguez wrote:
> > 
> > > > Also, you should probably invoke the script with $(BASH), else IIRC you
> > > > will break *BSD (where bash is in ports not /bin)
> > 
> > > This is a Linux script though,
> > 
> > True.
> > 
> > >  I'll use  #!/usr/bin/env bash
> > > instead then.
> > 
> > That's worse than either $(BASH) or a normal #! IMHO.
> 
> Do you mean to call $BASH foo.sh on the makefile ?

I meant $(BASH), or perhaps $(SHELL), but yes.

> On Linux we can run scripts often on Makefiles with
> either #!/bin/bash or the env thing just fine. I've
> never actually have seen the use of $(BASH) foo.sh
> within the Makefile.

Yes, it seems like you are right and we don't do this. I suppose because
all such #! lines are in Linux specific bits of the build. Sorry, I
guess I was confused by the presence of $(BASH) at all, combined with
the fact that we do jump through similar hoops for $(PYTHON).

So lets leave it as #! /bin/bash which appears to be the predominant
style.

>  I promise to address issues
> if found with this approach.

Thanks.

Ian.