From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v2 10/18] tools/misc: introduce helper to
	initialise Dom0
Date: Thu, 31 Jul 2014 09:34:20 +0100
Message-ID: <E1XClog-0006yy-KC@lists.xen.org>
References: <1406744639-28782-1-git-send-email-wei.liu2@citrix.com>
	<1406744639-28782-11-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1406744639-28782-11-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-07-30 at 19:23 +0100, Wei Liu wrote:

I don't think I'm going to have a chance to review this series in detail
but I noticed two little things while skimming:

> +    xch = xc_interface_open(0, 0, 0);
> +    if (!xch) {
> +        fprintf(stderr, "cannot open libxc handle\n");
> +        exit(1);
> +    }

AFAICT you don't do anything with this apart from closing it again.

> +    rc = libxl_userdata_store(ctx, 0, "libxl-json",
> +                              (const uint8_t *)json,
> +                              strlen(json) + 1 /* inlcude '\0' */);

"include"

Ian.