From: osstest service owner <osstest-admin@xenproject.org>
To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org
Subject: [xen-unstable-smoke bisection] complete build-arm64-xsm
Date: Thu, 08 Mar 2018 07:03:44 +0000 [thread overview]
Message-ID: <E1etpaa-0001B2-90@osstest.test-lab.xenproject.org> (raw)
branch xen-unstable-smoke
xenbranch xen-unstable-smoke
job build-arm64-xsm
testid xen-build
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
*** Found and reproduced problem changeset ***
Bug is in tree: xen git://xenbits.xen.org/xen.git
Bug introduced: 340edc3902c1757a0e1f4391930366fb25a05df3
Bug not present: 27254e45b102e933ec9b4fb630b384b708301095
Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/120335/
commit 340edc3902c1757a0e1f4391930366fb25a05df3
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Tue Feb 27 16:48:19 2018 +0000
xen/sched: Improvements to the {alloc,free}_domdata() interfaces
The main purpose of this change is for the subsequent cleanup it enables, but
it stands on its own merits.
In principle, these hooks are optional, but the SCHED_OP() default aliases a
memory allocation failure, which causes arinc653 to play the dangerous game of
passing its priv pointer back, and remembering not to actually free it.
Redefine alloc_domdata to use ERR_PTR() for errors, NULL for nothing, and
non-NULL for a real allocation, which allows the hook to become properly
optional. Redefine free_domdata to be idempotent.
For arinc653, this means the dummy hooks can be dropped entirely. For the
other schedulers, this means returning ERR_PTR(-ENOMEM) instead of NULL for
memory allocation failures, and modifying the free hooks to cope with a NULL
pointer. While making the alterations, drop some spurious casts to void *.
Introduce and use proper wrappers for sched_{alloc,free}_domdata(). These are
strictly better than SCHED_OP(), as the source code is visible to
grep/cscope/tags, the generated code is better, and there can be proper
per-hook defaults and checks.
Callers of the alloc hooks are switched to using IS_ERR(), rather than
checking for NULL.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
Acked-by: Meng Xu <mengxu@cis.upenn.edu>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
For bisection revision-tuple graph see:
http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable-smoke/build-arm64-xsm.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable-smoke/build-arm64-xsm.xen-build --summary-out=tmp/120335.bisection-summary --basis-template=120304 --blessings=real,real-bisect xen-unstable-smoke build-arm64-xsm xen-build
Searching for failure / basis pass:
120334 fail [host=laxton1] / 120304 ok.
Failure / basis pass flights: 120334 / 120304
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Latest a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e
Basis pass a19f3519ed720f103b56dc2969993a60e76ee3f1 8b022d0005d5b941cd078f640cae04711f5536c1
Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/qemu-xen.git#a19f3519ed720f103b56dc2969993a60e76ee3f1-a19f3519ed720f103b56dc2969993a60e76ee3f1 git://xenbits.xen.org/xen.git#8b022d0005d5b941cd078f640cae04711f5536c1-c9bd8a73656d7435b1055ee8825823aee995993e
Loaded 1001 nodes in revision graph
Searching for test results:
120313 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e
120304 pass a19f3519ed720f103b56dc2969993a60e76ee3f1 8b022d0005d5b941cd078f640cae04711f5536c1
120315 pass a19f3519ed720f103b56dc2969993a60e76ee3f1 8b022d0005d5b941cd078f640cae04711f5536c1
120316 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e
120317 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e
120322 pass a19f3519ed720f103b56dc2969993a60e76ee3f1 27254e45b102e933ec9b4fb630b384b708301095
120321 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e
120325 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c3715dd8fb766eb6f90d9cd81ef892f917845238
120328 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 340edc3902c1757a0e1f4391930366fb25a05df3
120330 pass a19f3519ed720f103b56dc2969993a60e76ee3f1 27254e45b102e933ec9b4fb630b384b708301095
120329 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e
120331 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 340edc3902c1757a0e1f4391930366fb25a05df3
120333 pass a19f3519ed720f103b56dc2969993a60e76ee3f1 27254e45b102e933ec9b4fb630b384b708301095
120334 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 c9bd8a73656d7435b1055ee8825823aee995993e
120335 fail a19f3519ed720f103b56dc2969993a60e76ee3f1 340edc3902c1757a0e1f4391930366fb25a05df3
Searching for interesting versions
Result found: flight 120304 (pass), for basis pass
Result found: flight 120313 (fail), for basis failure
Repro found: flight 120315 (pass), for basis pass
Repro found: flight 120316 (fail), for basis failure
0 revisions at a19f3519ed720f103b56dc2969993a60e76ee3f1 27254e45b102e933ec9b4fb630b384b708301095
No revisions left to test, checking graph state.
Result found: flight 120322 (pass), for last pass
Result found: flight 120328 (fail), for first failure
Repro found: flight 120330 (pass), for last pass
Repro found: flight 120331 (fail), for first failure
Repro found: flight 120333 (pass), for last pass
Repro found: flight 120335 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen git://xenbits.xen.org/xen.git
Bug introduced: 340edc3902c1757a0e1f4391930366fb25a05df3
Bug not present: 27254e45b102e933ec9b4fb630b384b708301095
Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/120335/
commit 340edc3902c1757a0e1f4391930366fb25a05df3
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Tue Feb 27 16:48:19 2018 +0000
xen/sched: Improvements to the {alloc,free}_domdata() interfaces
The main purpose of this change is for the subsequent cleanup it enables, but
it stands on its own merits.
In principle, these hooks are optional, but the SCHED_OP() default aliases a
memory allocation failure, which causes arinc653 to play the dangerous game of
passing its priv pointer back, and remembering not to actually free it.
Redefine alloc_domdata to use ERR_PTR() for errors, NULL for nothing, and
non-NULL for a real allocation, which allows the hook to become properly
optional. Redefine free_domdata to be idempotent.
For arinc653, this means the dummy hooks can be dropped entirely. For the
other schedulers, this means returning ERR_PTR(-ENOMEM) instead of NULL for
memory allocation failures, and modifying the free hooks to cope with a NULL
pointer. While making the alterations, drop some spurious casts to void *.
Introduce and use proper wrappers for sched_{alloc,free}_domdata(). These are
strictly better than SCHED_OP(), as the source code is visible to
grep/cscope/tags, the generated code is better, and there can be proper
per-hook defaults and checks.
Callers of the alloc hooks are switched to using IS_ERR(), rather than
checking for NULL.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
Acked-by: Meng Xu <mengxu@cis.upenn.edu>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
Revision graph left in /home/logs/results/bisect/xen-unstable-smoke/build-arm64-xsm.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
120335: tolerable ALL FAIL
flight 120335 xen-unstable-smoke real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/120335/
Failures :-/ but no regressions.
Tests which did not succeed,
including tests which could not be run:
build-arm64-xsm 6 xen-build fail baseline untested
jobs:
build-arm64-xsm fail
------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images
Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs
Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master
Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2018-03-08 7:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 7:03 osstest service owner [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-08 7:13 [xen-unstable-smoke bisection] complete build-arm64-xsm osstest service owner
2022-09-30 0:06 osstest service owner
2021-07-06 20:34 osstest service owner
2021-05-18 19:57 osstest service owner
2021-02-02 4:17 osstest service owner
2021-01-15 20:46 osstest service owner
2020-10-24 2:26 osstest service owner
2020-05-29 15:11 osstest service owner
2019-05-21 18:46 osstest service owner
2018-10-09 21:55 osstest service owner
2018-04-13 1:17 osstest service owner
2018-04-06 1:15 osstest service owner
2018-03-14 2:29 osstest service owner
2018-03-14 7:59 ` Jan Beulich
2018-03-14 9:01 ` Andrew Cooper
2018-03-14 10:54 ` Wei Liu
2018-03-14 13:42 ` Doug Goldstein
2018-01-27 3:32 osstest service owner
2018-01-25 21:47 osstest service owner
2018-01-17 2:07 osstest service owner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1etpaa-0001B2-90@osstest.test-lab.xenproject.org \
--to=osstest-admin@xenproject.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).