xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: osstest service owner <osstest-admin@xenproject.org>
To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org
Subject: [ovmf bisection] complete build-amd64
Date: Sat, 07 Apr 2018 10:57:16 +0000	[thread overview]
Message-ID: <E1f4lX2-00076w-Eq@osstest.test-lab.xenproject.org> (raw)

branch xen-unstable
xenbranch xen-unstable
job build-amd64
testid xen-build

Tree: ovmf https://github.com/tianocore/edk2.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  ovmf https://github.com/tianocore/edk2.git
  Bug introduced:  0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c
  Bug not present: d22c995a481485d8240453a9e5ea9af1d87a4c80
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/122030/


  commit 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c
  Author: Kinney, Michael D <michael.d.kinney@intel.com>
  Date:   Tue Apr 3 06:40:24 2018 +0800
  
      MdeModulePkg/Gcd: Filter gCpu->SetMemoryAttributes() calls
      
      This patch fixes an issue with VlvTbltDevicePkg introduced
      by commit 5b91bf82c67b586b9588cbe4bbffa1588f6b5926.
      
      The history is as below.
      To support heap guard feature, 14dde9e903bb9a719ebb8f3381da72b19509bc36
      added support for SetMemorySpaceAttributes() to handle page attributes,
      but after that, a combination of CPU arch attributes and other attributes
      was not allowed anymore, for example, UC + RUNTIME. It is a regression.
      Then 5b91bf82c67b586b9588cbe4bbffa1588f6b5926 was to fix the regression,
      and we thought 0 CPU arch attributes may be used to clear CPU arch
      attributes, so 0 CPU arch attributes was allowed to be sent to
      gCpu->SetMemoryAttributes().
      
      But some implementation of CPU driver may return error for 0 CPU arch
      attributes. That fails the case that caller just calls
      SetMemorySpaceAttributes() with none CPU arch attributes (for example,
      RUNTIME), and the purpose of the case is not to clear CPU arch attributes.
      
      This patch filters the call to gCpu->SetMemoryAttributes()
      if the requested attributes is 0.  It also removes the #define
      INVALID_CPU_ARCH_ATTRIBUTES that is no longer used.
      
      Cc: Heyi Guo <heyi.guo@linaro.org>
      Cc: Yi Li <phoenix.liyi@huawei.com>
      Cc: Renhao Liang <liangrenhao@huawei.com>
      Cc: Star Zeng <star.zeng@intel.com>
      Cc: Eric Dong <eric.dong@intel.com>
      Cc: Liming Gao <liming.gao@intel.com>
      Cc: Jian J Wang <jian.j.wang@intel.com>
      Cc: Ruiyu Ni <ruiyu.ni@intel.com>
      Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
      Signed-off-by: Star Zeng <star.zeng@intel.com>
      Contributed-under: TianoCore Contribution Agreement 1.1
      Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
      Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-amd64.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-amd64.xen-build --summary-out=tmp/122030.bisection-summary --basis-template=121769 --blessings=real,real-bisect ovmf build-amd64 xen-build
Searching for failure / basis pass:
 121977 fail [host=godello1] / 121769 [host=italia1] 121741 [host=godello0] 121710 [host=godello0] 121669 [host=elbling1] 121490 [host=italia1] 121374 ok.
Failure / basis pass flights: 121977 / 121374
(tree with no url: minios)
(tree with no url: seabios)
Tree: ovmf https://github.com/tianocore/edk2.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
Basis pass 3d7ebd6434311f6cf7e9dbb42c9db0f6f3185085 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
Generating revisions with ./adhoc-revtuple-generator  https://github.com/tianocore/edk2.git#3d7ebd6434311f6cf7e9dbb42c9db0f6f3185085-0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c git://xenbits.xen.org/qemu-xen-traditional.git#c8ea0457495342c417c3dc033bba25148b279f60-c8ea0457495342c417c3dc033bba25148b279f60 git://xenbits.xen.org/qemu-xen.git#5c3fdee026a204a59cb392e43a313ab558de9682-5c3fdee026a204a59cb392e43a313ab558de9682 git://xenbits.xen.org/xen.git#eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf-eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
Loaded 1001 nodes in revision graph
Searching for test results:
 121374 pass 3d7ebd6434311f6cf7e9dbb42c9db0f6f3185085 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 121372 [host=huxelrebe1]
 121488 [host=italia1]
 121490 [host=italia1]
 121663 [host=huxelrebe1]
 121669 [host=elbling1]
 121741 [host=godello0]
 121710 [host=godello0]
 121769 [host=italia1]
 121901 [host=godello0]
 122022 pass d22c995a481485d8240453a9e5ea9af1d87a4c80 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 121977 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 122023 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 122004 [host=godello0]
 122024 pass d22c995a481485d8240453a9e5ea9af1d87a4c80 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 122006 pass 3d7ebd6434311f6cf7e9dbb42c9db0f6f3185085 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 121976 [host=godello0]
 121993 [host=godello0]
 121994 [host=godello0]
 121995 [host=godello0]
 122012 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 121999 [host=godello0]
 122001 [host=godello0]
 122026 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 122015 pass de4f7f52f2003b854a754e3815f0a0c1c611118f c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 122029 pass d22c995a481485d8240453a9e5ea9af1d87a4c80 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 122016 pass 00c5eede482104f0f92f988805a604655060fd35 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 122018 pass 456c4ccab27b79f1b9c8d13ddcb5ed5453c09c53 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 122030 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 122020 pass 9686a4678de78e797e1368b9ff131890d3dee41b c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
Searching for interesting versions
 Result found: flight 121374 (pass), for basis pass
 Result found: flight 121977 (fail), for basis failure
 Repro found: flight 122006 (pass), for basis pass
 Repro found: flight 122012 (fail), for basis failure
 0 revisions at d22c995a481485d8240453a9e5ea9af1d87a4c80 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
No revisions left to test, checking graph state.
 Result found: flight 122022 (pass), for last pass
 Result found: flight 122023 (fail), for first failure
 Repro found: flight 122024 (pass), for last pass
 Repro found: flight 122026 (fail), for first failure
 Repro found: flight 122029 (pass), for last pass
 Repro found: flight 122030 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  ovmf https://github.com/tianocore/edk2.git
  Bug introduced:  0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c
  Bug not present: d22c995a481485d8240453a9e5ea9af1d87a4c80
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/122030/


  commit 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c
  Author: Kinney, Michael D <michael.d.kinney@intel.com>
  Date:   Tue Apr 3 06:40:24 2018 +0800
  
      MdeModulePkg/Gcd: Filter gCpu->SetMemoryAttributes() calls
      
      This patch fixes an issue with VlvTbltDevicePkg introduced
      by commit 5b91bf82c67b586b9588cbe4bbffa1588f6b5926.
      
      The history is as below.
      To support heap guard feature, 14dde9e903bb9a719ebb8f3381da72b19509bc36
      added support for SetMemorySpaceAttributes() to handle page attributes,
      but after that, a combination of CPU arch attributes and other attributes
      was not allowed anymore, for example, UC + RUNTIME. It is a regression.
      Then 5b91bf82c67b586b9588cbe4bbffa1588f6b5926 was to fix the regression,
      and we thought 0 CPU arch attributes may be used to clear CPU arch
      attributes, so 0 CPU arch attributes was allowed to be sent to
      gCpu->SetMemoryAttributes().
      
      But some implementation of CPU driver may return error for 0 CPU arch
      attributes. That fails the case that caller just calls
      SetMemorySpaceAttributes() with none CPU arch attributes (for example,
      RUNTIME), and the purpose of the case is not to clear CPU arch attributes.
      
      This patch filters the call to gCpu->SetMemoryAttributes()
      if the requested attributes is 0.  It also removes the #define
      INVALID_CPU_ARCH_ATTRIBUTES that is no longer used.
      
      Cc: Heyi Guo <heyi.guo@linaro.org>
      Cc: Yi Li <phoenix.liyi@huawei.com>
      Cc: Renhao Liang <liangrenhao@huawei.com>
      Cc: Star Zeng <star.zeng@intel.com>
      Cc: Eric Dong <eric.dong@intel.com>
      Cc: Liming Gao <liming.gao@intel.com>
      Cc: Jian J Wang <jian.j.wang@intel.com>
      Cc: Ruiyu Ni <ruiyu.ni@intel.com>
      Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
      Signed-off-by: Star Zeng <star.zeng@intel.com>
      Contributed-under: TianoCore Contribution Agreement 1.1
      Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
      Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Revision graph left in /home/logs/results/bisect/ovmf/build-amd64.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
122030: tolerable ALL FAIL

flight 122030 ovmf real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/122030/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-amd64                   6 xen-build               fail baseline untested


jobs:
 build-amd64                                                  fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

             reply	other threads:[~2018-04-07 10:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-07 10:57 osstest service owner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-05-01 16:26 [ovmf bisection] complete build-amd64 osstest service owner
2022-03-01 11:04 osstest service owner
2021-12-09 13:25 osstest service owner
2021-09-01 14:34 osstest service owner
2019-01-09  4:07 osstest service owner
2018-11-08  3:37 osstest service owner
2018-07-19  5:12 osstest service owner
2017-09-10 21:15 osstest service owner
2017-09-06 14:37 osstest service owner
2017-07-05 22:10 osstest service owner
2017-06-09 21:10 osstest service owner
2016-06-30  7:00 osstest service owner
2015-06-13 13:13 osstest service user
2015-05-21  6:59 osstest service user
2015-05-21  8:54 ` Ian Campbell
2015-01-31 14:29 xen.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1f4lX2-00076w-Eq@osstest.test-lab.xenproject.org \
    --to=osstest-admin@xenproject.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).