Re: [PATCH 1 of 1] Update ZFS sources from illumos.org:

[Igor Kozhukhov <ikozhukhov@gmail.com>]

Hi Ian,

we can use:
https://github.com/illumos/illumos-gate/tree/master/usr/src/grub@2acef22db7808606888f8f92715629ff3ba555b9

will it be correct ?
change set after '@'

about -Werror

by GCC specific, if we want to disable some warnings we should add rules after -Werror.
example:
-Werror -Wno-parentheses -Wno-unused

if we add rules "-Wno-parentheses -Wno-unused" before "-Werror" - they will be ignored and we will have build problem.

--
Best regards,
Igor Kozhukhov




On Nov 11, 2013, at 8:57 PM, Igor Kozhukhov wrote:

> could you please let me know what i need to do next ?
> 
> --
> Best regards,
> Igor Kozhukhov
> 
> 
> 
> 
> On Nov 11, 2013, at 8:40 PM, Ian Campbell wrote:
> 
>> On Mon, 2013-11-11 at 17:38 +0100, Egger, Christoph wrote:
>>> On 11.11.13 17:23, Ian Campbell wrote:
>>>>> Signed-off-by: Igor Kozhukhov <ikozhukhov@gmail.com>
>>>>> Asked-by: Ian Campbell <Ian.Campbell@citrix.com>
>>>> 
>>>> This isn't one of our standard tags, I take it you didn't mean Acked-by,
>>>> since I didn't ack it. I think all I did was ask for submitting patches
>>>> to be followed etc, no need to credit me for that IMHO.
>>> 
>>> Maybe he should use "Questioned-by" to make clear this is not a typo :-)
>> 
>> Or just skip it?
>> 
>> 
>