From: Paul Durrant <Paul.Durrant@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian Jackson <Ian.Jackson@citrix.com>,
"Tim (Xen.org)" <tim@xen.org>, "Keir (Xen.org)" <keir@xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 1/2] public/io/netif.h: document transmit and receive wire formats separately
Date: Mon, 11 Jan 2016 15:59:41 +0000 [thread overview]
Message-ID: <a0465b45ae21423a9d8879878a9d86f3@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5693DDEA02000078000C587B@prv-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 11 January 2016 15:53
> To: Paul Durrant
> Cc: Ian Campbell; Ian Jackson; xen-devel@lists.xenproject.org; Keir
> (Xen.org); Tim (Xen.org)
> Subject: Re: [PATCH v5 1/2] public/io/netif.h: document transmit and receive
> wire formats separately
>
> >>> On 11.01.16 at 16:25, <paul.durrant@citrix.com> wrote:
> > Currently there is no documented wire format for guest receive-side
> > packets but the location of the 'wire format' comment block suggests
> > it is the same as transmit-side. This is almost true but there is a
> > subtle difference in the use of the 'size' field for the first fragment.
> >
> > For clarity this patch creates separate comment blocks for receive
> > and transmit side packet wire formats, tries to be more clear about the
> > distinction between 'fragments' and 'extras', and documents the subtlety
> > concerning the size field of the first fragment.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Jan Beulich <jbeulich@suse.com>
> > Cc: Keir Fraser <keir@xen.org>
> > Cc: Tim Deegan <tim@xen.org>
> > ---
> >
> > v5:
> > - Add extra clarifications.
>
> Di you perhaps not notice that v4 went in, and hence an incremental
> patch would be needed?
Nope, clearly I didn't. I did not see an Acked-by so I didn't check.
I'll send v6 with an incremental patch.
Paul
>
> Jan
next prev parent reply other threads:[~2016-01-11 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 15:25 [PATCH v5 0/3] public/io/netif.h: support for toeplitz hashing Paul Durrant
2016-01-11 15:25 ` [PATCH v5 1/2] public/io/netif.h: document transmit and receive wire formats separately Paul Durrant
2016-01-11 15:52 ` Jan Beulich
2016-01-11 15:59 ` Paul Durrant [this message]
2016-01-11 15:25 ` [PATCH v5 2/2] public/io/netif.h: document control ring and toeplitz hashing Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0465b45ae21423a9d8879878a9d86f3@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).