xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86: partially undo "fix build with gcc 7"
Date: Thu, 1 Jun 2017 18:47:21 +0100	[thread overview]
Message-ID: <a2bc315d-32ff-cccc-e193-9995f1e52ade@arm.com> (raw)
In-Reply-To: <59301331020000780015EA87@prv-mh.provo.novell.com>

Hi,

On 01/06/17 12:14, Jan Beulich wrote:
>>>> On 01.06.17 at 13:06, <julien.grall@arm.com> wrote:
>> On 31/05/17 08:51, Jan Beulich wrote:
>>> While f32400e90c ("x86: fix build with gcc 7")'s change to
>>> compat_array_access_ok() is necessary, I had blindly and needlessly
>>> also added it to array_access_ok(). There's no conditional expression
>>> involved there, so undo it.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>> ---
>>> No ARM counterpart, as Julien means to remove the macro anyway.
>>
>> To double-check, I am CCed on this e-mail because you would like this
>> patch in Xen 4.9, right?
>
> No, because of the "No ARM counterpart ..." remark. Of course
> I wouldn't mind this going into 4.9, but I did specifically not submit
> the patch before branching because the code as is will do there. I
> simply didn't want to leave this in place for the longer term.

Oh. Yes the patch has been sent and acked by Stefano. Hopefully it will 
get merged soon.

Regarding the patch, I would avoid to add it in Xen 4.9 if it is not 
fixing a regression/critical bug.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      reply	other threads:[~2017-06-01 17:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31  7:51 [PATCH] x86: partially undo "fix build with gcc 7" Jan Beulich
2017-05-31 12:24 ` Andrew Cooper
2017-06-01 11:06 ` Julien Grall
2017-06-01 11:14   ` Jan Beulich
2017-06-01 17:47     ` Julien Grall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2bc315d-32ff-cccc-e193-9995f1e52ade@arm.com \
    --to=julien.grall@arm.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).