xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com,
	George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] Use non-debug build for Xen 4.10
Date: Wed, 29 Nov 2017 14:22:24 +0000	[thread overview]
Message-ID: <a3011713-2924-bfe9-88a7-e7b1a86e2f5c@linaro.org> (raw)
In-Reply-To: <5A1EC432020000780019318C@prv-mh.provo.novell.com>

Hi Jan,

On 11/29/2017 01:29 PM, Jan Beulich wrote:
>>>> On 29.11.17 at 13:09, <julien.grall@linaro.org> wrote:
>> Modify Config.mk and Kconfig.debug to disable debug by default in
>> preparation for late RCs and eventual release.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>
>> ---
>>
>> I would like this to get included before branching. So we can cut the RC
>> right after branching.
> 
> I think doing this before branching has proven a bad idea in the
> past, due to Coverity seeing a sufficiently different set of issues
> in both modes.

If Coverity requires debug then the .config used for coverity should 
have CONFIG_DEBUG=y.

So, I find rather strange to have to delay that patch just because of 
Coverity.

> I therefore think that turning off debug should
> actually be part of branching (e.g. be the first commit on the new
> stable branch).

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2017-11-29 14:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 12:09 [PATCH] Use non-debug build for Xen 4.10 Julien Grall
2017-11-29 13:29 ` Jan Beulich
2017-11-29 14:22   ` Julien Grall [this message]
2017-11-29 14:27     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3011713-2924-bfe9-88a7-e7b1a86e2f5c@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).