xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xen.org
Cc: Kevin Tian <kevin.tian@intel.com>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Jan Beulich <jbeulich@suse.com>,
	Razvan Cojocaru <rcojocaru@bitdefender.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Jun Nakajima <jun.nakajima@intel.com>
Subject: Re: [PATCH 00/15] xen/x86: Clean-up the PoD code
Date: Wed, 13 Sep 2017 19:30:27 +0100	[thread overview]
Message-ID: <a3a4b58e-0e18-698a-0a1d-7f47efd1eec7@citrix.com> (raw)
In-Reply-To: <20170913175953.16942-1-julien.grall@arm.com>

On 13/09/2017 18:59, Julien Grall wrote:
> Hi all
>
> I have been attempting to use the PoD code on ARM (it will be sent in a
> separate series) and spent sometimes to clean-up and switch to typesafe gfn
> the current code.
>
> The PoD code has been tested on ARM (the version is slightly different, mostly
> renaming) and the x86 part as only been built test it.
>
> Cheers,
>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Jun Nakajima <jun.nakajima@intel.com>
> Cc: Kevin Tian <kevin.tian@intel.com>
> Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>
> Cc: Tamas K Lengyel <tamas@tklengyel.com>
>
> Julien Grall (15):
>   xen/x86: p2m-pod: Clean-up includes
>   xen/x86: p2m-pod: Remove trailing whitespaces
>   xen/x86: p2m-pod: Fix coding style for comments
>   xen/x86: p2m-pod: Fix coding style
>   xen/x86: p2m-pod: Avoid redundant assignments in
>     p2m_pod_demand_populate
>   xen/x86: p2m-pod: Clean-up use of typesafe MFN
>   xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_decrease_reservation
>   xen/x86: p2m: Use typesafe gfn for the P2M callbacks get_entry and
>     set_entry
>   xen/x86: p2m: Use typesafe GFN in p2m_set_entry
>   xen/x86: p2m-pod: Use typesafe GFN in pod_eager_record
>   xen/x86: p2m-pod: Clean-up p2m_pod_zero_check
>   xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_zero_check
>   xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_demand_populate
>   xen/x86: p2m-pod: Use typesafe gfn for the fields reclaim_single and
>     max_guest
>   xen/x86: p2m-pod: Rework prototype of p2m_pod_demand_populate

Only the one minor comment on patch 8, and its knock-on effect in later
patches.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> (with either my
suggestion, or a suitable alternative)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      parent reply	other threads:[~2017-09-13 18:30 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 17:59 [PATCH 00/15] xen/x86: Clean-up the PoD code Julien Grall
2017-09-13 17:59 ` [PATCH 01/15] xen/x86: p2m-pod: Clean-up includes Julien Grall
2017-09-13 17:59 ` [PATCH 02/15] xen/x86: p2m-pod: Remove trailing whitespaces Julien Grall
2017-09-13 17:59 ` [PATCH 03/15] xen/x86: p2m-pod: Fix coding style for comments Julien Grall
2017-09-13 17:59 ` [PATCH 04/15] xen/x86: p2m-pod: Fix coding style Julien Grall
2017-09-13 17:59 ` [PATCH 05/15] xen/x86: p2m-pod: Avoid redundant assignments in p2m_pod_demand_populate Julien Grall
2017-09-13 17:59 ` [PATCH 06/15] xen/x86: p2m-pod: Clean-up use of typesafe MFN Julien Grall
2017-09-13 17:59 ` [PATCH 07/15] xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_decrease_reservation Julien Grall
2017-09-13 17:59 ` [PATCH 08/15] xen/x86: p2m: Use typesafe gfn for the P2M callbacks get_entry and set_entry Julien Grall
2017-09-13 18:22   ` Andrew Cooper
2017-09-13 18:27     ` Julien Grall
2017-09-13 19:10       ` Razvan Cojocaru
2017-09-13 19:08   ` Razvan Cojocaru
2017-09-13 19:32     ` Julien Grall
2017-09-20  6:57   ` Tian, Kevin
2017-09-13 17:59 ` [PATCH 09/15] xen/x86: p2m: Use typesafe GFN in p2m_set_entry Julien Grall
2017-09-13 20:16   ` Tamas K Lengyel
2017-09-13 17:59 ` [PATCH 10/15] xen/x86: p2m-pod: Use typesafe GFN in pod_eager_record Julien Grall
2017-09-13 17:59 ` [PATCH 11/15] xen/x86: p2m-pod: Clean-up p2m_pod_zero_check Julien Grall
2017-09-13 17:59 ` [PATCH 12/15] xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_zero_check Julien Grall
2017-09-13 17:59 ` [PATCH 13/15] xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_demand_populate Julien Grall
2017-09-13 17:59 ` [PATCH 14/15] xen/x86: p2m-pod: Use typesafe gfn for the fields reclaim_single and max_guest Julien Grall
2017-09-13 17:59 ` [PATCH 15/15] xen/x86: p2m-pod: Rework prototype of p2m_pod_demand_populate Julien Grall
2017-09-13 18:30 ` Andrew Cooper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3a4b58e-0e18-698a-0a1d-7f47efd1eec7@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@arm.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=rcojocaru@bitdefender.com \
    --cc=tamas@tklengyel.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).