From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xen.org
Subject: [PATCH 1 of 5] xend/pvscsi: fix passing of SCSI control LUNs
Date: Fri, 05 Oct 2012 18:22:37 +0200 [thread overview]
Message-ID: <a4053f1f58ec42a24c96.1349454157@probook.site> (raw)
In-Reply-To: <patchbomb.1349454156@probook.site>
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1349453188 -7200
# Node ID a4053f1f58ec42a24c963cac98d66f27fa54b8cc
# Parent 3eb9a891889a734a21643f02dac19b1b0cbe53f7
xend/pvscsi: fix passing of SCSI control LUNs
Currently pvscsi can not pass SCSI devices that have just a scsi_generic node.
In the following example sg3 is a control LUN for the disk sdd.
But vscsi=['4:0:2:0,0:0:0:0'] does not work because the internal 'devname'
variable remains None. Later writing p-devname to xenstore fails because None
is not a valid string variable.
Since devname is used for just informational purpose use sg also as devname.
carron:~ $ lsscsi -g
[0:0:0:0] disk ATA FK0032CAAZP HPF2 /dev/sda /dev/sg0
[4:0:0:0] disk HP P2000G3 FC/iSCSI T100 /dev/sdb /dev/sg1
[4:0:1:0] disk HP P2000G3 FC/iSCSI T100 /dev/sdc /dev/sg2
[4:0:2:0] storage HP HSV400 0950 - /dev/sg3
[4:0:2:1] disk HP HSV400 0950 /dev/sdd /dev/sg4
[4:0:3:0] storage HP HSV400 0950 - /dev/sg5
[4:0:3:1] disk HP HSV400 0950 /dev/sde /dev/sg6
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
diff -r 3eb9a891889a -r a4053f1f58ec tools/python/xen/util/vscsi_util.py
--- a/tools/python/xen/util/vscsi_util.py
+++ b/tools/python/xen/util/vscsi_util.py
@@ -105,6 +105,8 @@ def _vscsi_get_scsidevices_by_lsscsi(opt
devname = None
try:
sg = s[-1].split('/dev/')[1]
+ if devname is None:
+ devname = sg
scsi_id = _vscsi_get_scsiid(sg)
except IndexError:
sg = None
next prev parent reply other threads:[~2012-10-05 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 16:22 [PATCH 0 of 5] misc tools changes, backport request Olaf Hering
2012-10-05 16:22 ` Olaf Hering [this message]
2012-10-05 16:22 ` [PATCH 2 of 5] xend/pvscsi: fix usage of persistant device names for SCSI devices Olaf Hering
2012-10-05 16:22 ` [PATCH 3 of 5] xend/pvscsi: update sysfs parser for Linux 3.0 Olaf Hering
2012-10-05 16:22 ` [PATCH 4 of 5] stubdom: fix parallel build by expanding CROSS_MAKE Olaf Hering
2012-10-05 16:22 ` [PATCH 5 of 5] tools/configure.ac: fill PACKAGE_TARNAME in AC_INIT Olaf Hering
2012-10-08 11:19 ` [PATCH 0 of 5] misc tools changes, backport request Ian Campbell
2012-11-13 18:09 ` Ian Jackson
2012-11-13 18:15 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4053f1f58ec42a24c96.1349454157@probook.site \
--to=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).