From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v3] xen-netfront: Improve error handling during initialization Date: Wed, 8 Feb 2017 09:34:51 -0500 Message-ID: References: <1486551457-25963-1-git-send-email-ross.lagerwall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbTJT-0008A5-Fg for xen-devel@lists.xenproject.org; Wed, 08 Feb 2017 14:33:39 +0000 In-Reply-To: <1486551457-25963-1-git-send-email-ross.lagerwall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Ross Lagerwall , xen-devel@lists.xenproject.org Cc: Juergen Gross , netdev@vger.kernel.org, wei.liu2@citrix.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org T24gMDIvMDgvMjAxNyAwNTo1NyBBTSwgUm9zcyBMYWdlcndhbGwgd3JvdGU6Cj4gVGhpcyBmaXhl cyBhIGNyYXNoIHdoZW4gcnVubmluZyBvdXQgb2YgZ3JhbnQgcmVmcyB3aGVuIGNyZWF0aW5nIG1h bnkKPiBxdWV1ZXMgYWNyb3NzIG1hbnkgbmV0ZGV2cy4KPgo+ICogSWYgY3JlYXRpbmcgcXVldWVz IGZhaWxzIChpLmUuIHRoZXJlIGFyZSBubyBncmFudCByZWZzIGF2YWlsYWJsZSksCj4gY2FsbCB4 ZW5idXNfZGV2X2ZhdGFsKCkgdG8gZW5zdXJlIHRoYXQgdGhlIHhlbmJ1cyBkZXZpY2UgaXMgc2V0 IHRvIHRoZQo+IGNsb3NlZCBzdGF0ZS4KPiAqIElmIG5vIHF1ZXVlcyBhcmUgY3JlYXRlZCwgZG9u J3QgY2FsbCB4ZW5uZXRfZGlzY29ubmVjdF9iYWNrZW5kIGFzCj4gbmV0ZGV2LT5yZWFsX251bV90 eF9xdWV1ZXMgd2lsbCBub3QgaGF2ZSBiZWVuIHNldCBjb3JyZWN0bHkuCj4gKiBJZiBzZXR1cF9u ZXRmcm9udCgpIGZhaWxzLCBlbnN1cmUgdGhhdCBhbGwgdGhlIHF1ZXVlcyBjcmVhdGVkIGFyZQo+ IGNsZWFuZWQgdXAsIG5vdCBqdXN0IHRob3NlIHRoYXQgaGF2ZSBiZWVuIHNldCB1cC4KPiAqIElm IGFueSBxdWV1ZXMgd2VyZSBzZXQgdXAgYW5kIGFuIGVycm9yIG9jY3VycywgY2FsbAo+IHhlbm5l dF9kZXN0cm95X3F1ZXVlcygpIHRvIGNsZWFuIHVwIHRoZSBuYXBpIGNvbnRleHQuCj4gKiBJZiBh bnkgZmF0YWwgZXJyb3Igb2NjdXJzLCB1bnJlZ2lzdGVyIGFuZCBkZXN0cm95IHRoZSBuZXRkZXYg dG8gYXZvaWQKPiBsZWF2aW5nIGFyb3VuZCBhIGhhbGYgc2V0dXAgbmV0d29yayBkZXZpY2UuCj4K PiBTaWduZWQtb2ZmLWJ5OiBSb3NzIExhZ2Vyd2FsbCA8cm9zcy5sYWdlcndhbGxAY2l0cml4LmNv bT4KPiAtLS0KPgo+IENoYW5nZWQgaW4gVjM6Cj4gKiBJZiB4ZW5uZXRfY3JlYXRlX3F1ZXVlcyBy ZXR1cm5zIDwgMCwgaXQgd2lsbCBub3QgaGF2ZSBjcmVhdGVkIGFueQo+ICAgcXVldWVzIHNvIHRo ZXJlJ3Mgbm8gbmVlZCB0byBnbyB0byBkZXN0cm95X3JpbmcuCj4KPiAgZHJpdmVycy9uZXQveGVu LW5ldGZyb250LmMgfCAyOSArKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9uZXQveGVuLW5ldGZyb250LmMgYi9kcml2ZXJzL25ldC94ZW4tbmV0ZnJvbnQu Ywo+IGluZGV4IDcyMmZlOWYuLmY5MGZjNzIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9uZXQveGVu LW5ldGZyb250LmMKPiArKysgYi9kcml2ZXJzL25ldC94ZW4tbmV0ZnJvbnQuYwo+IEBAIC0xODIz LDI3ICsxODIzLDE5IEBAIHN0YXRpYyBpbnQgdGFsa190b19uZXRiYWNrKHN0cnVjdCB4ZW5idXNf ZGV2aWNlICpkZXYsCj4gIAkJeGVubmV0X2Rlc3Ryb3lfcXVldWVzKGluZm8pOwo+ICAKPiAgCWVy ciA9IHhlbm5ldF9jcmVhdGVfcXVldWVzKGluZm8sICZudW1fcXVldWVzKTsKPiAtCWlmIChlcnIg PCAwKQo+IC0JCWdvdG8gZGVzdHJveV9yaW5nOwo+ICsJaWYgKGVyciA8IDApIHsKPiArCQl4ZW5i dXNfZGV2X2ZhdGFsKGRldiwgZXJyLCAiY3JlYXRpbmcgcXVldWVzIik7Cj4gKwkJa2ZyZWUoaW5m by0+cXVldWVzKTsKPiArCQlpbmZvLT5xdWV1ZXMgPSBOVUxMOwo+ICsJCWdvdG8gb3V0Owo+ICsJ fQoKSSB0aGluayBpdCBtaWdodCBiZSBiZXR0ZXIgdG8ga2ZyZWUoKSBpbiB4ZW5uZXRfY3JlYXRl X3F1ZXVlcygpIChhbmQgc2V0Cm51bV9xdWV1ZXMgdG8gemVybywgd2hpbGUgYXQgaXQpLiBCdXQg ZWl0aGVyIHdheToKClJldmlld2VkLWJ5OiBCb3JpcyBPc3Ryb3Zza3kgPGJvcmlzLm9zdHJvdnNr eUBvcmFjbGUuY29tPgoKCj4gIAo+ICAJLyogQ3JlYXRlIHNoYXJlZCByaW5nLCBhbGxvYyBldmVu dCBjaGFubmVsIC0tIGZvciBlYWNoIHF1ZXVlICovCj4gIAlmb3IgKGkgPSAwOyBpIDwgbnVtX3F1 ZXVlczsgKytpKSB7Cj4gIAkJcXVldWUgPSAmaW5mby0+cXVldWVzW2ldOwo+ICAJCWVyciA9IHNl dHVwX25ldGZyb250KGRldiwgcXVldWUsIGZlYXR1cmVfc3BsaXRfZXZ0Y2huKTsKPiAtCQlpZiAo ZXJyKSB7Cj4gLQkJCS8qIHNldHVwX25ldGZyb250KCkgd2lsbCB0aWR5IHVwIHRoZSBjdXJyZW50 Cj4gLQkJCSAqIHF1ZXVlIG9uIGVycm9yLCBidXQgd2UgbmVlZCB0byBjbGVhbiB1cAo+IC0JCQkg KiB0aG9zZSBhbHJlYWR5IGFsbG9jYXRlZC4KPiAtCQkJICovCj4gLQkJCWlmIChpID4gMCkgewo+ IC0JCQkJcnRubF9sb2NrKCk7Cj4gLQkJCQluZXRpZl9zZXRfcmVhbF9udW1fdHhfcXVldWVzKGlu Zm8tPm5ldGRldiwgaSk7Cj4gLQkJCQlydG5sX3VubG9jaygpOwo+IC0JCQkJZ290byBkZXN0cm95 X3Jpbmc7Cj4gLQkJCX0gZWxzZSB7Cj4gLQkJCQlnb3RvIG91dDsKPiAtCQkJfQo+IC0JCX0KPiAr CQlpZiAoZXJyKQo+ICsJCQlnb3RvIGRlc3Ryb3lfcmluZzsKPiAgCX0KPiAgCj4gIGFnYWluOgo+ IEBAIC0xOTMzLDkgKzE5MjUsMTAgQEAgc3RhdGljIGludCB0YWxrX3RvX25ldGJhY2soc3RydWN0 IHhlbmJ1c19kZXZpY2UgKmRldiwKPiAgCXhlbmJ1c190cmFuc2FjdGlvbl9lbmQoeGJ0LCAxKTsK PiAgIGRlc3Ryb3lfcmluZzoKPiAgCXhlbm5ldF9kaXNjb25uZWN0X2JhY2tlbmQoaW5mbyk7Cj4g LQlrZnJlZShpbmZvLT5xdWV1ZXMpOwo+IC0JaW5mby0+cXVldWVzID0gTlVMTDsKPiArCXhlbm5l dF9kZXN0cm95X3F1ZXVlcyhpbmZvKTsKPiAgIG91dDoKPiArCXVucmVnaXN0ZXJfbmV0ZGV2KGlu Zm8tPm5ldGRldik7Cj4gKwl4ZW5uZXRfZnJlZV9uZXRkZXYoaW5mby0+bmV0ZGV2KTsKPiAgCXJl dHVybiBlcnI7Cj4gIH0KPiAgCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9y ZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==