From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case
Date: Thu, 13 Sep 2018 11:41:08 +0000 [thread overview]
Message-ID: <a6d92a1e05454a13a9abc6fa55bfcd9b@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5B9A4C6902000078001E8280@prv1-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 13 September 2018 12:39
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; xen-devel <xen-
> devel@lists.xenproject.org>
> Subject: RE: [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for
> multi-page case
>
> >>> On 13.09.18 at 13:06, <Paul.Durrant@citrix.com> wrote:
> >> From: Jan Beulich [mailto:JBeulich@suse.com]
> >> Sent: 13 September 2018 11:13
> >>
> >> @@ -544,7 +574,7 @@ static void *hvmemul_map_linear_addr(
> >> struct hvm_emulate_ctxt *hvmemul_ctxt)
> >> {
> >> struct vcpu *curr = current;
> >> - void *err, *mapping;
> >> + void *err = ZERO_BLOCK_PTR, *mapping;
> >
> > Given the revised logic, can't you just start *err with the value
> > ERR_PTR(~X86EMUL_OKAY) now? You can then lose the extra test in the
> first if
> > of update_map_err().
>
> No, I don't think I can, because of ...
>
> >> unsigned int nr_frames = ((linear + bytes - !!bytes) >>
> PAGE_SHIFT) -
> >> (linear >> PAGE_SHIFT) + 1;
> >> unsigned int i;
> >> @@ -600,27 +630,28 @@ static void *hvmemul_map_linear_addr(
> >> goto out;
> >>
> >> case HVMTRANS_bad_gfn_to_mfn:
> >> - err = NULL;
> >> - goto out;
> >> + err = update_map_err(err, NULL);
> >> + continue;
> >>
> >> case HVMTRANS_gfn_paged_out:
> >> case HVMTRANS_gfn_shared:
> >> - err = ERR_PTR(~X86EMUL_RETRY);
> >> - goto out;
> >> + err = update_map_err(err, ERR_PTR(~X86EMUL_RETRY));
> >> + continue;
> >>
> >> default:
> >> - goto unhandleable;
> >> + err = update_map_err(err, ERR_PTR(~X86EMUL_UNHANDLEABLE));
> >> + continue;
> >> }
> >>
> >> *mfn++ = page_to_mfn(page);
> >>
> >> if ( p2m_is_discard_write(p2mt) )
> >> - {
> >> - err = ERR_PTR(~X86EMUL_OKAY);
> >> - goto out;
> >> - }
> >> + err = update_map_err(err, ERR_PTR(~X86EMUL_OKAY));
>
> ... this and ...
>
> >> }
> >>
> >> + if ( err != ZERO_BLOCK_PTR )
> >> + goto out;
>
> ... this.
Ah yes. In which case...
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
>
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-13 11:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 9:09 [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case Jan Beulich
2018-09-12 11:51 ` Paul Durrant
2018-09-12 12:13 ` Jan Beulich
2018-09-13 10:12 ` [PATCH v2] " Jan Beulich
2018-09-13 11:06 ` Paul Durrant
2018-09-13 11:39 ` Jan Beulich
2018-09-13 11:41 ` Paul Durrant [this message]
2018-09-20 12:41 ` Andrew Cooper
2018-09-20 13:39 ` Jan Beulich
2018-09-20 14:13 ` Andrew Cooper
2018-09-20 14:51 ` Jan Beulich
2018-09-25 12:41 ` Jan Beulich
2018-09-25 15:30 ` Andrew Cooper
2018-09-26 9:27 ` Jan Beulich
2018-10-08 11:53 ` Jan Beulich
2019-07-31 11:26 ` [Xen-devel] " Alexandru Stefan ISAILA
2023-08-30 14:30 ` [Xen-devel] [PATCH] " Roger Pau Monné
2023-08-30 18:09 ` Andrew Cooper
2023-08-31 7:03 ` Jan Beulich
2023-08-31 8:59 ` Roger Pau Monné
2023-08-31 7:14 ` [Xen-devel] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6d92a1e05454a13a9abc6fa55bfcd9b@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).